Support Statement.NO_GENERATED_KEYS option

Add a proper behaviour when Connection.prepareStatement,
Statement.execute, and Statement.executeUpdate are called with the
Statement.NO_GENERATED_KEYS flag.

Return an empty generated keys when the Statement.NO_GENERATED_KEYS is
set as a special case of a generated keys absence.

Fixes: #78

Author: nicktorwald

Diff for: src/main/java/org/tarantool/jdbc/SQLConnection.java

@@ -3,6 +3,7 @@
 import org.tarantool.CommunicationException;
 import org.tarantool.JDBCBridge;
 import org.tarantool.TarantoolConnection;
+import org.tarantool.util.JdbcConstants;
 import org.tarantool.util.SQLStates;
 
 import java.io.IOException;
@@ -40,7 +41,6 @@
 import static org.tarantool.jdbc.SQLDriver.PROP_SOCKET_TIMEOUT;
 import static org.tarantool.jdbc.SQLDriver.PROP_USER;
 
-@SuppressWarnings("Since15")
 public class SQLConnection implements Connection {
 
     private static final int UNSET_HOLDABILITY = 0;
@@ -341,7 +341,12 @@ public CallableStatement prepareCall(String sql, int resultSetType, int resultSe
 
     @Override
     public PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) throws SQLException {
-        throw new SQLFeatureNotSupportedException();
+        checkNotClosed();
+        JdbcConstants.checkGeneratedKeysConstant(autoGeneratedKeys);
+        if (autoGeneratedKeys != Statement.NO_GENERATED_KEYS) {
+            throw new SQLFeatureNotSupportedException();
+        }
+        return prepareStatement(sql);
     }
 
     @Override

Diff for: src/main/java/org/tarantool/jdbc/SQLStatement.java

@@ -1,6 +1,7 @@
 package org.tarantool.jdbc;
 
 import org.tarantool.JDBCBridge;
+import org.tarantool.util.JdbcConstants;
 
 import java.sql.Connection;
 import java.sql.ResultSet;
@@ -220,12 +221,18 @@ public boolean getMoreResults(int current) throws SQLException {
 
     @Override
     public ResultSet getGeneratedKeys() throws SQLException {
-        throw new SQLFeatureNotSupportedException();
+        checkNotClosed();
+        return new SQLResultSet(JDBCBridge.EMPTY, this);
     }
 
     @Override
     public int executeUpdate(String sql, int autoGeneratedKeys) throws SQLException {
-        throw new SQLFeatureNotSupportedException();
+        checkNotClosed();
+        JdbcConstants.checkGeneratedKeysConstant(autoGeneratedKeys);
+        if (autoGeneratedKeys != Statement.NO_GENERATED_KEYS) {
+            throw new SQLFeatureNotSupportedException();
+        }
+        return executeUpdate(sql);
     }
 
     @Override
@@ -240,7 +247,12 @@ public int executeUpdate(String sql, String[] columnNames) throws SQLException {
 
     @Override
     public boolean execute(String sql, int autoGeneratedKeys) throws SQLException {
-        throw new SQLFeatureNotSupportedException();
+        checkNotClosed();
+        JdbcConstants.checkGeneratedKeysConstant(autoGeneratedKeys);
+        if (autoGeneratedKeys != Statement.NO_GENERATED_KEYS) {
+            throw new SQLFeatureNotSupportedException();
+        }
+        return execute(sql);
     }
 
     @Override

Diff for: src/main/java/org/tarantool/util/JdbcConstants.java

@@ -7,6 +7,13 @@
 
 public class JdbcConstants {
 
+    public static void checkGeneratedKeysConstant(int autoGeneratedKeys) throws SQLException {
+        if (autoGeneratedKeys != Statement.NO_GENERATED_KEYS
+                && autoGeneratedKeys != Statement.RETURN_GENERATED_KEYS) {
+            throw new SQLNonTransientException("", SQLStates.INVALID_PARAMETER_VALUE.getSqlState());
+        }
+    }
+
     public static void checkHoldabilityConstant(int holdability) throws SQLException {
         if (holdability != ResultSet.CLOSE_CURSORS_AT_COMMIT
                 && holdability != ResultSet.HOLD_CURSORS_OVER_COMMIT) {

Diff for: src/test/java/org/tarantool/jdbc/JdbcConnectionIT.java

@@ -192,4 +192,23 @@ public void testPrepareHoldableStatement() throws SQLException {
         });
     }
 
+    @Test
+    public void testGeneratedKeys() throws SQLException {
+        String sql = "SELECT * FROM test";
+        PreparedStatement preparedStatement = conn.prepareStatement(sql, Statement.NO_GENERATED_KEYS);
+        assertNotNull(preparedStatement);
+        preparedStatement.close();
+
+        assertThrows(SQLFeatureNotSupportedException.class, () -> conn.prepareStatement(sql, new int[] { 1 }));
+        assertThrows(SQLFeatureNotSupportedException.class, () -> conn.prepareStatement(sql, new String[] { "id" }));
+
+        assertThrows(SQLException.class, () -> conn.prepareStatement(sql, Integer.MAX_VALUE));
+        assertThrows(SQLException.class, () -> conn.prepareStatement(sql, Integer.MIN_VALUE));
+        assertThrows(SQLException.class, () -> conn.prepareStatement(sql, -76));
+        assertThrows(
+                SQLFeatureNotSupportedException.class,
+                () -> conn.prepareStatement(sql, Statement.RETURN_GENERATED_KEYS)
+        );
+    }
 }
+

Diff for: src/test/java/org/tarantool/jdbc/JdbcDatabaseMetaDataIT.java

@@ -254,4 +254,9 @@ public void testSupportsResultSetHoldability() throws SQLException {
         assertFalse(meta.supportsResultSetHoldability(42));
     }
 
+    @Test
+    public void testSupportGeneratedKeys() throws SQLException {
+        assertFalse(meta.supportsGetGeneratedKeys());
+    }
+
 }

Diff for: src/test/java/org/tarantool/jdbc/JdbcPreparedStatementIT.java

@@ -9,6 +9,7 @@
 import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
+import java.sql.Statement;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -104,6 +105,8 @@ public void testExecuteReturnsUpdateCount() throws Exception {
 
         assertEquals("ten", getRow("test", 10).get(1));
         assertEquals("twenty", getRow("test", 20).get(1));
+
+        conn.createStatement().execute("DELETE FROM test WHERE id IN (10, 20)");
     }
 
     @Test void testForbiddenMethods() throws SQLException {
@@ -161,6 +164,18 @@ public void execute() throws Throwable {
         assertEquals(3, i);
     }
 
+    @Test
+    public void testSupportGeneratedKeys() throws SQLException {
+        prep = conn.prepareStatement("INSERT INTO test values (50, 'fifty')", Statement.NO_GENERATED_KEYS);
+        assertFalse(prep.execute());
+        assertEquals(1, prep.getUpdateCount());
+
+        ResultSet generatedKeys = prep.getGeneratedKeys();
+        assertNotNull(generatedKeys);
+        assertEquals(ResultSet.TYPE_FORWARD_ONLY, generatedKeys.getType());
+        assertEquals(ResultSet.CONCUR_READ_ONLY, generatedKeys.getConcurrency());
+    }
+
     @Test
     public void testSetByte() throws SQLException {
         makeHelper(Byte.class)

Diff for: src/test/java/org/tarantool/jdbc/JdbcStatementIT.java

@@ -78,11 +78,14 @@ public void testClosedConnection() throws Exception {
                 @Override
                 public void execute() throws Throwable {
                     switch (step) {
-                        case 0: stmt.executeQuery("TEST");
+                        case 0:
+                            stmt.executeQuery("TEST");
                             break;
-                        case 1: stmt.executeUpdate("TEST");
+                        case 1:
+                            stmt.executeUpdate("TEST");
                             break;
-                        case 2: stmt.execute("TEST");
+                        case 2:
+                            stmt.execute("TEST");
                             break;
                         default:
                             fail();
@@ -93,4 +96,38 @@ public void execute() throws Throwable {
         }
         assertEquals(3, i);
     }
+
+    @Test
+    public void testSupportedGeneratedKeys() throws SQLException {
+        int affectedRows = stmt.executeUpdate(
+                "INSERT INTO test(id, val) VALUES (50, 'fifty')",
+                Statement.NO_GENERATED_KEYS
+        );
+        assertEquals(1, affectedRows);
+        ResultSet generatedKeys = stmt.getGeneratedKeys();
+        assertNotNull(generatedKeys);
+        assertEquals(ResultSet.TYPE_FORWARD_ONLY, generatedKeys.getType());
+        assertEquals(ResultSet.CONCUR_READ_ONLY, generatedKeys.getConcurrency());
+    }
+
+    @Test
+    void testUnsupportedGeneratedKeys() {
+        assertThrows(
+                SQLException.class,
+                () -> stmt.executeUpdate(
+                        "INSERT INTO test(id, val) VALUES (100, 'hundred'), (1000, 'thousand')",
+                        Statement.RETURN_GENERATED_KEYS
+                )
+        );
+
+        int[] wrongConstants = {Integer.MAX_VALUE, Integer.MIN_VALUE, -31, 344};
+        for (int wrongConstant : wrongConstants) {
+            assertThrows(SQLException.class,
+                    () -> stmt.executeUpdate(
+                            "INSERT INTO test(id, val) VALUES (100, 'hundred'), (1000, 'thousand')",
+                            wrongConstant
+                    )
+            );
+        }
+    }
 }