Skip to content

Commit 599e3f4

Browse files
olegrokDifferentialOrange
authored andcommitted
iproto: disable feature discovery for specific versions
"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported. Closes #283 [1] tarantool/tarantool@2cbec82#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947
1 parent 6fb3490 commit 599e3f4

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7+
## Unreleased
8+
9+
### Changed
10+
- Discovery iproto features only for Tarantools since version 2.10.0 (#283).
11+
712
## 0.12.0 - 2023-02-13
813

914
### Added

tarantool/connection.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1014,7 +1014,8 @@ def handshake(self):
10141014
if greeting.protocol != "Binary":
10151015
raise NetworkError("Unsupported protocol: " + greeting.protocol)
10161016
self.version_id = greeting.version_id
1017-
self._check_features()
1017+
if self.version_id >= version_id(2, 10, 0):
1018+
self._check_features()
10181019
self.uuid = greeting.uuid
10191020
self._salt = greeting.salt
10201021
if self.user:

0 commit comments

Comments
 (0)