Skip to content

Commit e52e35e

Browse files
pylint: fix singleton-comparison cases
Fix all cases of C0121 singleton-comparison. Part of #270
1 parent 23a444f commit e52e35e

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

tarantool/connection_pool.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ def build(self):
240240

241241
any_pool.append(key)
242242

243-
if state.read_only == False:
243+
if state.read_only is False:
244244
rw_pool.append(key)
245245
else:
246246
ro_pool.append(key)
@@ -620,7 +620,7 @@ def is_closed(self):
620620
:rtype: :obj:`bool`
621621
"""
622622

623-
return all(unit.request_processing_enabled == False for unit in self.pool.values())
623+
return all(unit.request_processing_enabled is False for unit in self.pool.values())
624624

625625
def _request_process_loop(self, key, unit, last_refresh):
626626
"""

test/suites/__init__.py

+28-28
Original file line numberDiff line numberDiff line change
@@ -4,35 +4,35 @@
44
__tmp = os.getcwd()
55
os.chdir(os.path.abspath(os.path.dirname(__file__)))
66

7-
from .test_schema import TestSuite_Schema_UnicodeConnection
8-
from .test_schema import TestSuite_Schema_BinaryConnection
9-
from .test_dml import TestSuite_Request
10-
from .test_protocol import TestSuite_Protocol
11-
from .test_reconnect import TestSuite_Reconnect
12-
from .test_mesh import TestSuite_Mesh
13-
from .test_pool import TestSuite_Pool
14-
from .test_execute import TestSuite_Execute
15-
from .test_dbapi import TestSuite_DBAPI
16-
from .test_encoding import TestSuite_Encoding
17-
from .test_ssl import TestSuite_Ssl
18-
from .test_decimal import TestSuite_Decimal
19-
from .test_uuid import TestSuite_UUID
20-
from .test_datetime import TestSuite_Datetime
21-
from .test_interval import TestSuite_Interval
22-
from .test_package import TestSuite_Package
23-
from .test_error_ext import TestSuite_ErrorExt
24-
from .test_push import TestSuite_Push
25-
from .test_connection import TestSuite_Connection
26-
from .test_crud import TestSuite_Crud
7+
from .test_schema import TestSuiteSchemaUnicodeConnection
8+
from .test_schema import TestSuiteSchemaBinaryConnection
9+
from .test_dml import TestSuiteRequest
10+
from .test_protocol import TestSuiteProtocol
11+
from .test_reconnect import TestSuiteReconnect
12+
from .test_mesh import TestSuiteMesh
13+
from .test_pool import TestSuitePool
14+
from .test_execute import TestSuiteExecute
15+
from .test_dbapi import TestSuiteDBAPI
16+
from .test_encoding import TestSuiteEncoding
17+
from .test_ssl import TestSuiteSsl
18+
from .test_decimal import TestSuiteDecimal
19+
from .test_uuid import TestSuiteUUID
20+
from .test_datetime import TestSuiteDatetime
21+
from .test_interval import TestSuiteInterval
22+
from .test_package import TestSuitePackage
23+
from .test_error_ext import TestSuiteErrorExt
24+
from .test_push import TestSuitePush
25+
from .test_connection import TestSuiteConnection
26+
from .test_crud import TestSuiteCrud
2727

28-
test_cases = (TestSuite_Schema_UnicodeConnection,
29-
TestSuite_Schema_BinaryConnection,
30-
TestSuite_Request, TestSuite_Protocol, TestSuite_Reconnect,
31-
TestSuite_Mesh, TestSuite_Execute, TestSuite_DBAPI,
32-
TestSuite_Encoding, TestSuite_Pool, TestSuite_Ssl,
33-
TestSuite_Decimal, TestSuite_UUID, TestSuite_Datetime,
34-
TestSuite_Interval, TestSuite_ErrorExt, TestSuite_Push,
35-
TestSuite_Connection, TestSuite_Crud,)
28+
test_cases = (TestSuiteSchemaUnicodeConnection,
29+
TestSuiteSchemaBinaryConnection,
30+
TestSuiteRequest, TestSuiteProtocol, TestSuiteReconnect,
31+
TestSuiteMesh, TestSuiteExecute, TestSuiteDBAPI,
32+
TestSuiteEncoding, TestSuitePool, TestSuiteSsl,
33+
TestSuiteDecimal, TestSuiteUUID, TestSuiteDatetime,
34+
TestSuiteInterval, TestSuiteErrorExt, TestSuitePush,
35+
TestSuiteConnection, TestSuiteCrud,)
3636

3737
def load_tests(loader, tests, pattern):
3838
suite = unittest.TestSuite()

test/suites/test_crud.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def setUp(self):
4141
fetch_schema=False)
4242
# Time for vshard group configuration.
4343
time.sleep(1)
44-
if self.conn.eval('return ROCKS_IMPORT_FAIL').data[0] == True:
44+
if self.conn.eval('return ROCKS_IMPORT_FAIL').data[0] is True:
4545
raise unittest.SkipTest('The crud/vshard modules are not detected, ' +
4646
'installation via rocks install is required ' +
4747
'for CRUD testing purposes. You can use ' +

0 commit comments

Comments
 (0)