Skip to content

Commit cbfeb44

Browse files
tatethurstonTate
tatethurston
and
Tate
authored
remove unnecessary isEndGroup check in serializer (#65)
Co-authored-by: Tate <[email protected]>
1 parent 19c10e1 commit cbfeb44

File tree

19 files changed

+0
-435
lines changed

19 files changed

+0
-435
lines changed

Diff for: ‎e2e-tests/clientcompat/src/clientcompat.pb.ts

-12
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,6 @@ export const Empty = {
135135

136136
readMessage: function (msg: Partial<Empty>, reader: BinaryReader): void {
137137
while (reader.nextField()) {
138-
if (reader.isEndGroup()) {
139-
break;
140-
}
141138
const field = reader.getFieldNumber();
142139
switch (field) {
143140
default: {
@@ -175,9 +172,6 @@ export const Req = {
175172

176173
readMessage: function (msg: Partial<Req>, reader: BinaryReader): void {
177174
while (reader.nextField()) {
178-
if (reader.isEndGroup()) {
179-
break;
180-
}
181175
const field = reader.getFieldNumber();
182176
switch (field) {
183177
case 1: {
@@ -224,9 +218,6 @@ export const Resp = {
224218

225219
readMessage: function (msg: Partial<Resp>, reader: BinaryReader): void {
226220
while (reader.nextField()) {
227-
if (reader.isEndGroup()) {
228-
break;
229-
}
230221
const field = reader.getFieldNumber();
231222
switch (field) {
232223
case 1: {
@@ -285,9 +276,6 @@ export const ClientCompatMessage = {
285276
reader: BinaryReader
286277
): void {
287278
while (reader.nextField()) {
288-
if (reader.isEndGroup()) {
289-
break;
290-
}
291279
const field = reader.getFieldNumber();
292280
switch (field) {
293281
case 1: {

Diff for: ‎e2e-tests/test-protos/src/10/multi-service.pb.ts

-18
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,6 @@ export const InfoRequest = {
204204
reader: BinaryReader
205205
): void {
206206
while (reader.nextField()) {
207-
if (reader.isEndGroup()) {
208-
break;
209-
}
210207
const field = reader.getFieldNumber();
211208
switch (field) {
212209
default: {
@@ -243,9 +240,6 @@ export const DoStuffRequest = {
243240
reader: BinaryReader
244241
): void {
245242
while (reader.nextField()) {
246-
if (reader.isEndGroup()) {
247-
break;
248-
}
249243
const field = reader.getFieldNumber();
250244
switch (field) {
251245
default: {
@@ -286,9 +280,6 @@ export const InfoResponse = {
286280
reader: BinaryReader
287281
): void {
288282
while (reader.nextField()) {
289-
if (reader.isEndGroup()) {
290-
break;
291-
}
292283
const field = reader.getFieldNumber();
293284
switch (field) {
294285
case 1: {
@@ -338,9 +329,6 @@ export const DoStuffResponse = {
338329
reader: BinaryReader
339330
): void {
340331
while (reader.nextField()) {
341-
if (reader.isEndGroup()) {
342-
break;
343-
}
344332
const field = reader.getFieldNumber();
345333
switch (field) {
346334
case 1: {
@@ -393,9 +381,6 @@ export const VerifyRequest = {
393381
reader: BinaryReader
394382
): void {
395383
while (reader.nextField()) {
396-
if (reader.isEndGroup()) {
397-
break;
398-
}
399384
const field = reader.getFieldNumber();
400385
switch (field) {
401386
case 1: {
@@ -456,9 +441,6 @@ export const VerifyResponse = {
456441
reader: BinaryReader
457442
): void {
458443
while (reader.nextField()) {
459-
if (reader.isEndGroup()) {
460-
break;
461-
}
462444
const field = reader.getFieldNumber();
463445
switch (field) {
464446
case 1: {

Diff for: ‎e2e-tests/test-protos/src/24/long.pb.ts

-9
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,6 @@ export const VeryLongNameThatCausesAnError = {
111111
reader: BinaryReader
112112
): void {
113113
while (reader.nextField()) {
114-
if (reader.isEndGroup()) {
115-
break;
116-
}
117114
const field = reader.getFieldNumber();
118115
switch (field) {
119116
case 1: {
@@ -159,9 +156,6 @@ export const GetAllRequest = {
159156
reader: BinaryReader
160157
): void {
161158
while (reader.nextField()) {
162-
if (reader.isEndGroup()) {
163-
break;
164-
}
165159
const field = reader.getFieldNumber();
166160
switch (field) {
167161
default: {
@@ -198,9 +192,6 @@ export const GetAllResponse = {
198192
reader: BinaryReader
199193
): void {
200194
while (reader.nextField()) {
201-
if (reader.isEndGroup()) {
202-
break;
203-
}
204195
const field = reader.getFieldNumber();
205196
switch (field) {
206197
default: {

Diff for: ‎e2e-tests/test-protos/src/34/address.pb.ts

-12
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ export const GetUserResponse = {
6262
reader: BinaryReader
6363
): void {
6464
while (reader.nextField()) {
65-
if (reader.isEndGroup()) {
66-
break;
67-
}
6865
const field = reader.getFieldNumber();
6966
switch (field) {
7067
case 1: {
@@ -129,9 +126,6 @@ export const GetUserResponse = {
129126
reader: BinaryReader
130127
): void {
131128
while (reader.nextField()) {
132-
if (reader.isEndGroup()) {
133-
break;
134-
}
135129
const field = reader.getFieldNumber();
136130
switch (field) {
137131
case 1: {
@@ -206,9 +200,6 @@ export const GetUserResponse = {
206200
): void {
207201
msg.address = [];
208202
while (reader.nextField()) {
209-
if (reader.isEndGroup()) {
210-
break;
211-
}
212203
const field = reader.getFieldNumber();
213204
switch (field) {
214205
case 1: {
@@ -283,9 +274,6 @@ export const AddressValue = {
283274
reader: BinaryReader
284275
): void {
285276
while (reader.nextField()) {
286-
if (reader.isEndGroup()) {
287-
break;
288-
}
289277
const field = reader.getFieldNumber();
290278
switch (field) {
291279
case 1: {

Diff for: ‎e2e-tests/test-protos/src/7/a.pb.ts

-30
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,6 @@ export const Foo1Request = {
335335
msg.d = [];
336336
msg.e = [];
337337
while (reader.nextField()) {
338-
if (reader.isEndGroup()) {
339-
break;
340-
}
341338
const field = reader.getFieldNumber();
342339
switch (field) {
343340
case 1: {
@@ -421,9 +418,6 @@ export const Foo1Response = {
421418
msg.d = [];
422419
msg.e = [];
423420
while (reader.nextField()) {
424-
if (reader.isEndGroup()) {
425-
break;
426-
}
427421
const field = reader.getFieldNumber();
428422
switch (field) {
429423
case 1: {
@@ -507,9 +501,6 @@ export const Foo2Request = {
507501
msg.d = [];
508502
msg.e = [];
509503
while (reader.nextField()) {
510-
if (reader.isEndGroup()) {
511-
break;
512-
}
513504
const field = reader.getFieldNumber();
514505
switch (field) {
515506
case 1: {
@@ -593,9 +584,6 @@ export const Foo2Response = {
593584
msg.d = [];
594585
msg.e = [];
595586
while (reader.nextField()) {
596-
if (reader.isEndGroup()) {
597-
break;
598-
}
599587
const field = reader.getFieldNumber();
600588
switch (field) {
601589
case 1: {
@@ -679,9 +667,6 @@ export const Foo3Request = {
679667
msg.d = [];
680668
msg.e = [];
681669
while (reader.nextField()) {
682-
if (reader.isEndGroup()) {
683-
break;
684-
}
685670
const field = reader.getFieldNumber();
686671
switch (field) {
687672
case 1: {
@@ -765,9 +750,6 @@ export const Foo3Response = {
765750
msg.d = [];
766751
msg.e = [];
767752
while (reader.nextField()) {
768-
if (reader.isEndGroup()) {
769-
break;
770-
}
771753
const field = reader.getFieldNumber();
772754
switch (field) {
773755
case 1: {
@@ -851,9 +833,6 @@ export const Foo4Request = {
851833
msg.d = [];
852834
msg.e = [];
853835
while (reader.nextField()) {
854-
if (reader.isEndGroup()) {
855-
break;
856-
}
857836
const field = reader.getFieldNumber();
858837
switch (field) {
859838
case 1: {
@@ -937,9 +916,6 @@ export const Foo4Response = {
937916
msg.d = [];
938917
msg.e = [];
939918
while (reader.nextField()) {
940-
if (reader.isEndGroup()) {
941-
break;
942-
}
943919
const field = reader.getFieldNumber();
944920
switch (field) {
945921
case 1: {
@@ -1023,9 +999,6 @@ export const Foo5Request = {
1023999
msg.d = [];
10241000
msg.e = [];
10251001
while (reader.nextField()) {
1026-
if (reader.isEndGroup()) {
1027-
break;
1028-
}
10291002
const field = reader.getFieldNumber();
10301003
switch (field) {
10311004
case 1: {
@@ -1109,9 +1082,6 @@ export const Foo5Response = {
11091082
msg.d = [];
11101083
msg.e = [];
11111084
while (reader.nextField()) {
1112-
if (reader.isEndGroup()) {
1113-
break;
1114-
}
11151085
const field = reader.getFieldNumber();
11161086
switch (field) {
11171087
case 1: {

Diff for: ‎e2e-tests/test-protos/src/7/b.pb.ts

-30
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,6 @@ export const Foo1Request = {
335335
msg.d = [];
336336
msg.e = [];
337337
while (reader.nextField()) {
338-
if (reader.isEndGroup()) {
339-
break;
340-
}
341338
const field = reader.getFieldNumber();
342339
switch (field) {
343340
case 1: {
@@ -421,9 +418,6 @@ export const Foo1Response = {
421418
msg.d = [];
422419
msg.e = [];
423420
while (reader.nextField()) {
424-
if (reader.isEndGroup()) {
425-
break;
426-
}
427421
const field = reader.getFieldNumber();
428422
switch (field) {
429423
case 1: {
@@ -507,9 +501,6 @@ export const Foo2Request = {
507501
msg.d = [];
508502
msg.e = [];
509503
while (reader.nextField()) {
510-
if (reader.isEndGroup()) {
511-
break;
512-
}
513504
const field = reader.getFieldNumber();
514505
switch (field) {
515506
case 1: {
@@ -593,9 +584,6 @@ export const Foo2Response = {
593584
msg.d = [];
594585
msg.e = [];
595586
while (reader.nextField()) {
596-
if (reader.isEndGroup()) {
597-
break;
598-
}
599587
const field = reader.getFieldNumber();
600588
switch (field) {
601589
case 1: {
@@ -679,9 +667,6 @@ export const Foo3Request = {
679667
msg.d = [];
680668
msg.e = [];
681669
while (reader.nextField()) {
682-
if (reader.isEndGroup()) {
683-
break;
684-
}
685670
const field = reader.getFieldNumber();
686671
switch (field) {
687672
case 1: {
@@ -765,9 +750,6 @@ export const Foo3Response = {
765750
msg.d = [];
766751
msg.e = [];
767752
while (reader.nextField()) {
768-
if (reader.isEndGroup()) {
769-
break;
770-
}
771753
const field = reader.getFieldNumber();
772754
switch (field) {
773755
case 1: {
@@ -851,9 +833,6 @@ export const Foo4Request = {
851833
msg.d = [];
852834
msg.e = [];
853835
while (reader.nextField()) {
854-
if (reader.isEndGroup()) {
855-
break;
856-
}
857836
const field = reader.getFieldNumber();
858837
switch (field) {
859838
case 1: {
@@ -937,9 +916,6 @@ export const Foo4Response = {
937916
msg.d = [];
938917
msg.e = [];
939918
while (reader.nextField()) {
940-
if (reader.isEndGroup()) {
941-
break;
942-
}
943919
const field = reader.getFieldNumber();
944920
switch (field) {
945921
case 1: {
@@ -1023,9 +999,6 @@ export const Foo5Request = {
1023999
msg.d = [];
10241000
msg.e = [];
10251001
while (reader.nextField()) {
1026-
if (reader.isEndGroup()) {
1027-
break;
1028-
}
10291002
const field = reader.getFieldNumber();
10301003
switch (field) {
10311004
case 1: {
@@ -1109,9 +1082,6 @@ export const Foo5Response = {
11091082
msg.d = [];
11101083
msg.e = [];
11111084
while (reader.nextField()) {
1112-
if (reader.isEndGroup()) {
1113-
break;
1114-
}
11151085
const field = reader.getFieldNumber();
11161086
switch (field) {
11171087
case 1: {

0 commit comments

Comments
 (0)