-
-
Notifications
You must be signed in to change notification settings - Fork 51
Prevent forced use of <fieldset> for individual fields. #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@willnationsdev I don't have any strong reasons for keeping While a Field can have more than 1 control, in practice there isn't a guarantee. I wonder if it too should just become a div? One of the main reason's So in short, I'm all for changing it to a A PR would be awesome, and maybe someone else will chime in before we review/merge. Library is pre-1.0 for these types of revisions 😃 |
I like |
I noticed while using the package that TextField and SelectField both have a
<fieldset>
at the root while most other inputs have a<div>
. This causes problems for me in a codebase I am attempting to use this package for since I need to be able to put multiple inputs/fields into one fieldset (and also include a<legend>
as a header for that subset of fields).Would it be possible to update those two (and any others I missed) to likewise swap
<fieldset>
for<div>
so that users can handle that aspect themselves? Or if you don't want to break compatibility, perhaps use<svelte:element this={rootElement}>
with anexport let rootElement = "fieldset"
?I'd be happy to submit a PR myself if approved.
The text was updated successfully, but these errors were encountered: