Merge pull request #70 from technote-space/fix/#68

fix: consider fail to cancel (#68)

Author: technote-space

Diff for: __tests__/process.test.ts

@@ -422,4 +422,116 @@ describe('execute', () => {
       '::endgroup::',
     ]);
   });
+
+  it('should cancel jobs (some workflow runs fail to cancel)', async() => {
+    // workflow-run.list
+    // 30433642 run_number=562, updated_at=2020-02-22T19:33:08Z (re-run)          => expected that this will be cancelled (fail)
+    // 30433643 run_number=563, updated_at=2020-01-23T19:33:08Z (merge commit)    => expected that this will be cancelled
+    // 30433644 run_number=564, updated_at=2020-01-24T19:33:08Z (target run)      => expected that this will be cancelled (fail)
+    // 30433645 run_number=565, updated_at=2020-01-25T19:33:08Z                   => expected that this will not be cancelled
+    // 30433646~30433649                                        (different event) => expected that this will not be cancelled
+
+    const mockStdout = spyOnStdout();
+    nock('https://api.github.com')
+      .get('/repos/hello/world/actions/runs/30433644')
+      .reply(200, () => getApiFixture(fixturesDir, 'workflow-run.get.30433644'))
+      .get('/repos/hello/world/actions/workflows/111564/runs?status=in_progress&branch=release%2Fv1.2.3')
+      .reply(200, () => getApiFixture(fixturesDir, 'workflow-run.list'))
+      .post('/repos/hello/world/actions/runs/30433642/cancel')
+      .replyWithError({
+        message: 'Cannot cancel a workflow run that is completed.',
+        code: 409,
+      })
+      .post('/repos/hello/world/actions/runs/30433643/cancel')
+      .reply(202)
+      .post('/repos/hello/world/actions/runs/30433644/cancel')
+      .replyWithError({
+        message: 'Cannot cancel a workflow run that is completed.',
+        code: 409,
+      });
+
+    await execute(new Logger(), getOctokit(), generateContext({owner: 'hello', repo: 'world', event: 'pull_request'}, {
+      runId: 30433644,
+      payload: {
+        'pull_request': {
+          head: {
+            ref: 'release/v1.2.3',
+          },
+        },
+      },
+    }));
+
+    stdoutCalledWith(mockStdout, [
+      '> run id: 30433644',
+      '::group::run:',
+      getLogStdout({
+        'id': 30433644,
+        'head_branch': 'master',
+        'head_sha': 'acb5820ced9479c074f688cc328bf03f341a511d',
+        'run_number': 564,
+        'event': 'push',
+        'status': 'queued',
+        'created_at': '2020-01-24T19:33:08Z',
+        'updated_at': '2020-01-24T19:33:08Z',
+      }),
+      '::endgroup::',
+      '> workflow id: 111564',
+      'target event: \x1b[32;40mpull_request\x1b[0m',
+      'target branch: \x1b[32;40mrelease/v1.2.3\x1b[0m',
+      '::group::workflow runs:',
+      getLogStdout([
+        {
+          'id': 30433642,
+          'head_branch': 'master',
+          'head_sha': 'acb5820ced9479c074f688cc328bf03f341a511d',
+          'run_number': 562,
+          'event': 'pull_request',
+          'status': 'queued',
+          'created_at': '2020-01-22T19:33:08Z',
+          'updated_at': '2020-02-22T19:33:08Z',
+        },
+        {
+          'id': 30433643,
+          'head_branch': 'master',
+          'head_sha': 'acb5820ced9479c074f688cc328bf03f341a511d',
+          'run_number': 563,
+          'event': 'pull_request',
+          'status': 'queued',
+          'created_at': '2020-01-23T19:33:08Z',
+          'updated_at': '2020-01-23T19:33:08Z',
+        },
+        {
+          'id': 30433644,
+          'head_branch': 'master',
+          'head_sha': 'acb5820ced9479c074f688cc328bf03f341a511d',
+          'run_number': 564,
+          'event': 'pull_request',
+          'status': 'queued',
+          'created_at': '2020-01-24T19:33:08Z',
+          'updated_at': '2020-01-24T19:33:08Z',
+        },
+        {
+          'id': 30433645,
+          'head_branch': 'master',
+          'head_sha': 'acb5820ced9479c074f688cc328bf03f341a511d',
+          'run_number': 565,
+          'event': 'pull_request',
+          'status': 'queued',
+          'created_at': '2020-01-25T19:33:08Z',
+          'updated_at': '2020-01-25T19:33:08Z',
+        },
+      ]),
+      '::endgroup::',
+      '',
+      '::group::Cancelling...',
+      'cancel: 30433642',
+      '::error::request to https://api.github.com/repos/hello/world/actions/runs/30433642/cancel failed, reason: Cannot cancel a workflow run that is completed.',
+      'cancel: 30433643',
+      'cancel: 30433644',
+      '::error::request to https://api.github.com/repos/hello/world/actions/runs/30433644/cancel failed, reason: Cannot cancel a workflow run that is completed.',
+      '> total: 3',
+      '::set-output name=ids::30433642,30433643,30433644',
+      '::endgroup::',
+    ]);
+  });
 });

Diff for: src/process.ts

@@ -48,7 +48,11 @@ export const execute = async(logger: Logger, octokit: Octokit, context: Context)
   await targetRuns.reduce(async(prev, run) => {
     await prev;
     logger.log('cancel: %d', run.id);
-    await cancelWorkflowRun(run.id, octokit, context);
+    try {
+      await cancelWorkflowRun(run.id, octokit, context);
+    } catch (error) {
+      logger.error(error.message);
+    }
     if (interval) {
       await Utils.sleep(interval);
     }