[vm/ffi] Make callback SaveArguments platform agnostic

dcharkes · commit-bot@chromium.org · commit b3b38a92805f · 2020-10-12T21:12:22.000Z
Separated out from: https://dart-review.googlesource.com/c/sdk/+/140290/18. Issue: dart-lang#36730. Change-Id: I71a749ffe946c74033f7f047486f32746e93d79f Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-kernel-linux-debug-ia32-try,vm-kernel-linux-debug-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-win-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166849 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
diff --git a/assembler_ia32.h b/assembler_ia32.h
@@ -610,6 +610,9 @@ class Assembler : public AssemblerBase {
   }
 
   void AddImmediate(Register reg, const Immediate& imm);
+  void AddImmediate(Register reg, int32_t value) {
+    AddImmediate(reg, Immediate(value));
+  }
   void SubImmediate(Register reg, const Immediate& imm);
 
   void CompareImmediate(Register reg, int32_t immediate) {
diff --git a/assembler_x64.h b/assembler_x64.h
@@ -705,6 +705,9 @@ class Assembler : public AssemblerBase {
   void AddImmediate(Register reg,
                     const Immediate& imm,
                     OperandWidth width = k64Bit);
+  void AddImmediate(Register reg, int32_t value, OperandWidth width = k64Bit) {
+    AddImmediate(reg, Immediate(value), width);
+  }
   void AddImmediate(const Address& address, const Immediate& imm);
   void SubImmediate(Register reg,
                     const Immediate& imm,

Original file line number	Diff line number	Diff line change
`@@ -610,6 +610,9 @@ class Assembler : public AssemblerBase {`
`610`	`610`	`}`
`611`	`611`
`612`	`612`	`void AddImmediate(Register reg, const Immediate& imm);`
	`613`	`+ void AddImmediate(Register reg, int32_t value) {`
	`614`	`+ AddImmediate(reg, Immediate(value));`
	`615`	`+ }`
`613`	`616`	`void SubImmediate(Register reg, const Immediate& imm);`
`614`	`617`
`615`	`618`	`void CompareImmediate(Register reg, int32_t immediate) {`