Skip to content

Commit 05f0fd0

Browse files
committed
add globalPinsEnabled feature flag to the pinned view container
1 parent 0924bd3 commit 05f0fd0

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

tensorboard/webapp/metrics/views/main_view/pinned_view_component.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ import {CardIdWithMetadata} from '../metrics_view_types';
4545
</span>
4646
</span>
4747
</div>
48-
<div class="right-items" *ngIf="cardIdsWithMetadata.length > 0">
48+
<div
49+
class="right-items"
50+
*ngIf="cardIdsWithMetadata.length > 0 && globalPinsEnabled"
51+
>
4952
<button mat-stroked-button (click)="onClearAllPinsClicked.emit()">
5053
Clear all pins
5154
</button>
@@ -67,5 +70,6 @@ export class PinnedViewComponent {
6770
@Input() cardObserver!: CardObserver;
6871
@Input() cardIdsWithMetadata!: CardIdWithMetadata[];
6972
@Input() lastPinnedCardTime!: number;
73+
@Input() globalPinsEnabled: boolean = false;
7074
@Output() onClearAllPinsClicked = new EventEmitter<void>();
7175
}

tensorboard/webapp/metrics/views/main_view/pinned_view_container.ts

+4
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {getLastPinnedCardTime, getPinnedCardsWithMetadata} from '../../store';
2222
import {CardObserver} from '../card_renderer/card_lazy_loader';
2323
import {CardIdWithMetadata} from '../metrics_view_types';
2424
import {metricsClearAllPinnedCards} from '../../actions';
25+
import {getEnableGlobalPins} from '../../../selectors';
2526

2627
@Component({
2728
selector: 'metrics-pinned-view',
@@ -30,6 +31,7 @@ import {metricsClearAllPinnedCards} from '../../actions';
3031
[cardIdsWithMetadata]="cardIdsWithMetadata$ | async"
3132
[lastPinnedCardTime]="lastPinnedCardTime$ | async"
3233
[cardObserver]="cardObserver"
34+
[globalPinsEnabled]="globalPinsEnabled$ | async"
3335
(onClearAllPinsClicked)="onClearAllPinsClicked()"
3436
></metrics-pinned-view-component>
3537
`,
@@ -50,6 +52,8 @@ export class PinnedViewContainer {
5052
skip(1)
5153
);
5254

55+
readonly globalPinsEnabled$ = this.store.select(getEnableGlobalPins);
56+
5357
onClearAllPinsClicked() {
5458
this.store.dispatch(metricsClearAllPinnedCards());
5559
}

0 commit comments

Comments
 (0)