Skip to content

Commit 5ee586c

Browse files
authored
Avoids bad protobuf version 4.24.0 (#6746)
I should have added this condition in #6660. At the time I thought it wouldn't matter much, as I assumed users would most likely get a newer version installed, but on second thought, it would be better to have this check, just in case.
1 parent dcb1bb6 commit 5ee586c

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tensorboard/pip_package/requirements.txt

+5-3
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ numpy >= 1.12.0
2323
# NOTE: this version must be >= the protoc version in our WORKSPACE file.
2424
# At the same time, any constraints we specify here must allow at least some
2525
# version to be installed that is also compatible with TensorFlow's constraints:
26-
# https://github.com/tensorflow/tensorflow/blob/9d22f4a0a9499c8e10a4312503e63e0da35ccd94/tensorflow/tools/pip_package/setup.py#L100-L107
27-
protobuf >= 3.19.6
26+
# https://github.com/tensorflow/tensorflow/blob/25adc4fccb4b0bb5a933eba1d246380e7b87d7f7/tensorflow/tools/pip_package/setup.py#L101
27+
# 4.24.0 had an issue that broke our tests, so we should avoid that release:
28+
# https://github.com/protocolbuffers/protobuf/issues/13485
29+
protobuf >= 3.19.6, != 4.24.0
2830
setuptools >= 41.0.0 # Note: provides pkg_resources as well as setuptools
2931
# A dependency of our vendored packages. This lower bound has not been correctly
3032
# vetted, but I wanted to be the least restrictive we can, since it's not a new
@@ -34,4 +36,4 @@ tensorboard-data-server >= 0.7.0, < 0.8.0
3436
# Stay on Keras 2 for now: https://github.com/keras-team/keras/issues/18467.
3537
# TODO: Remove this after migrating to Keras 3.
3638
tf-keras >= 2.15.0
37-
werkzeug >= 1.0.1
39+
werkzeug >= 1.0.1

0 commit comments

Comments
 (0)