Skip to content

Commit 78569c0

Browse files
authored
ci: install TensorBoard deps after TensorFlow (#4807)
Summary: Installing `tf-nightly` pulls in `tb-nightly` and its dependencies. This installs over our `requirements.txt`, which matters when there are version differences. In particular, a PR that upgrades a dependency in `requirements.txt` should be tested on the new version, not the old one. Test Plan: A prior version of this PR also upgraded a package version. The “Check Pip state” action showed that we now test on the upgraded version. wchargin-branch: ci-fix-deps-install-order
1 parent 23d930d commit 78569c0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/ci.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,16 @@ jobs:
7474
"common --google_credentials=${creds_file}" \
7575
"common --remote_upload_local_results=true" \
7676
;
77+
- name: 'Install TensorFlow'
78+
run: pip install "${{ matrix.tf_version_id }}"
79+
if: matrix.tf_version_id != 'notf'
7780
- name: 'Install Python dependencies'
7881
run: |
7982
python -m pip install -U pip
8083
pip install \
8184
-r ./tensorboard/pip_package/requirements.txt \
8285
-r ./tensorboard/pip_package/requirements_dev.txt \
8386
;
84-
- name: 'Install TensorFlow'
85-
run: pip install "${{ matrix.tf_version_id }}"
86-
if: matrix.tf_version_id != 'notf'
8787
- name: 'Check Pip state'
8888
run: pip freeze --all
8989
- name: 'Bazel: fetch'

0 commit comments

Comments
 (0)