Skip to content

Commit 7abecdf

Browse files
authored
Remove some broken demos and demo annotations (#1647)
Summary: Some modules have `@demo` annotations that point to nonexistent demos, so we fix or remove those references as appropriate. The `google-chart` demo is not working and does not appear to have ever worked: when running it on its initial commit after cherry-picking #1334 we see only a blank page. However, deleting this demo isn’t trivial, because the main profile dashboard depends on it for some reason. As this plugin is still being actively developed, we’ll leave the demo alone for now: it’s not actually causing any problems. Context: <#1645 (comment)> Test Plan: Note that `git grep @demo` only lists correct paths to working demos. wchargin-branch: remove-broken-demos
1 parent 4991e24 commit 7abecdf

File tree

5 files changed

+2
-6
lines changed

5 files changed

+2
-6
lines changed

Diff for: tensorboard/components/vz_chart_helpers/vz-chart-tooltip.html

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
such as different X scales (linear and temporal), tooltips and smoothing.
2727
2828
@element vz-line-chart
29-
@demo demo/index.html
3029
-->
3130
<dom-module id="vz-chart-tooltip">
3231
<template>

Diff for: tensorboard/components/vz_line_chart/vz-line-chart.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
such as different X scales (linear and temporal), tooltips and smoothing.
3131
3232
@element vz-line-chart
33-
@demo demo/index.html
33+
@demo index.html
3434
-->
3535
<dom-module id="vz-line-chart">
3636
<template>

Diff for: tensorboard/components/vz_line_chart2/vz-line-chart2.html

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
such as different X scales (linear and temporal), tooltips and smoothing.
3232
3333
@element vz-line-chart
34-
@demo demo/index.html
3534
-->
3635
<dom-module id="vz-line-chart2">
3736
<template>

Diff for: tensorboard/plugins/histogram/vz_histogram_timeseries/vz-histogram-timeseries.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
visualization.
2727
2828
@element vz-histogram-timeseries
29-
@demo demo/index.html
29+
@demo index.html
3030
-->
3131
<dom-module id="vz-histogram-timeseries">
3232
<template>

Diff for: tensorboard/plugins/profile/google_chart/google-chart.html

-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@
7070
on the `html` tag of your document.
7171
7272
<html lang="ja">
73-
74-
@demo
7573
-->
7674
<dom-module id="google-chart">
7775
<template>

0 commit comments

Comments
 (0)