Skip to content

Commit cfc0b67

Browse files
authored
Fix copybara import errors (#6694)
## Motivation for features / changes Copybara sync will complain after #6692 : - Filterbar doesn't use lowerCamelCase in property names (it used a "_" prefix) - runs table BUILD target doesn't include chip dependencies (surprisingly this doesn't affect tests or app execution) This PR addresses both issues
1 parent 4431538 commit cfc0b67

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

tensorboard/webapp/runs/views/runs_table/BUILD

+2
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ tf_ng_module(
8282
"//tensorboard/webapp/alert/actions",
8383
"//tensorboard/webapp/angular:expect_angular_material_button",
8484
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
85+
"//tensorboard/webapp/angular:expect_angular_material_chips",
8586
"//tensorboard/webapp/angular:expect_angular_material_dialog",
8687
"//tensorboard/webapp/angular:expect_angular_material_form_field",
8788
"//tensorboard/webapp/angular:expect_angular_material_icon",
@@ -145,6 +146,7 @@ tf_ts_library(
145146
"//tensorboard/webapp/angular:expect_angular_cdk_overlay",
146147
"//tensorboard/webapp/angular:expect_angular_core_testing",
147148
"//tensorboard/webapp/angular:expect_angular_material_checkbox",
149+
"//tensorboard/webapp/angular:expect_angular_material_chips",
148150
"//tensorboard/webapp/angular:expect_angular_material_dialog",
149151
"//tensorboard/webapp/angular:expect_angular_material_input",
150152
"//tensorboard/webapp/angular:expect_angular_material_menu",

tensorboard/webapp/runs/views/runs_table/filterbar_component.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,14 @@ export class FilterbarComponent {
4444
@ViewChild('filterModal', {static: false})
4545
private readonly filterModal!: CustomModalComponent;
4646

47-
_selectedFilterName = '';
47+
private internalSelectedFilterName = '';
4848
get selectedFilterName(): string {
49-
return this._selectedFilterName;
49+
return this.internalSelectedFilterName;
5050
}
5151
set selectedFilterName(filterName: string) {
52-
this._selectedFilterName = filterName;
52+
this.internalSelectedFilterName = filterName;
5353
}
5454
// selectedFilter indirectly set using selectedFilterName.
55-
_selectedFilter?: DiscreteFilter | IntervalFilter | undefined;
5655
get selectedFilter(): DiscreteFilter | IntervalFilter | undefined {
5756
return this.filters.get(this.selectedFilterName);
5857
}

0 commit comments

Comments
 (0)