Skip to content

Commit d7fd4ad

Browse files
authored
MDCMigration: fix Column Editor Style (#6623)
## Motivation for features / changes After an update to the new MDC Components the style of this feature was messed up. This fixes that style. ## Screenshots of UI changes (or N/A) <img width="458" alt="Screenshot 2023-10-05 at 3 03 57 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/6ddc2e53-f129-4fc2-b06e-7a7e1debdb59"> <img width="456" alt="Screenshot 2023-10-05 at 3 04 04 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/961bca54-d8b3-4f5c-961e-014ba0d1bdcd"> <img width="476" alt="Screenshot 2023-10-05 at 3 04 17 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/8c66d5ec-16aa-42fd-92b8-fdea3623c8bf">
1 parent 526f9c1 commit d7fd4ad

File tree

3 files changed

+16
-22
lines changed

3 files changed

+16
-22
lines changed

tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/scalar_column_editor_component.ng.html

+14-16
Original file line numberDiff line numberDiff line change
@@ -51,21 +51,19 @@
5151
let-headers="headers"
5252
let-dataTableMode="dataTableMode"
5353
>
54-
<div class="header-list">
55-
<div
56-
class="header-list-item"
57-
*ngFor="let header of headers;"
58-
draggable="true"
59-
(dragstart)="dragStart(header)"
60-
(dragend)="dragEnd(dataTableMode)"
61-
(dragenter)="dragEnter(header, dataTableMode)"
62-
[ngClass]="getHighlightClasses(header)"
63-
>
64-
<mat-checkbox
65-
[checked]="header.enabled"
66-
(change)="toggleHeader(header, dataTableMode)"
67-
><tb-data-table-header [header]="header"></tb-data-table-header
68-
></mat-checkbox>
69-
</div>
54+
<div
55+
class="header-list-item"
56+
*ngFor="let header of headers;"
57+
draggable="true"
58+
(dragstart)="dragStart(header)"
59+
(dragend)="dragEnd(dataTableMode)"
60+
(dragenter)="dragEnter(header, dataTableMode)"
61+
[ngClass]="getHighlightClasses(header)"
62+
>
63+
<mat-checkbox
64+
[checked]="header.enabled"
65+
(change)="toggleHeader(header, dataTableMode)"
66+
><tb-data-table-header [header]="header"></tb-data-table-header
67+
></mat-checkbox>
7068
</div>
7169
</ng-template>

tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/scalar_column_editor_component.scss

+2-5
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,10 @@ $_accent: map-get(mat.get-color-config($tb-theme), accent);
3232
z-index: 0;
3333
height: 100%;
3434
}
35-
.header-list {
36-
margin-top: 5%;
37-
margin-left: 5%;
38-
}
3935

4036
.header-list-item {
4137
padding: 3px;
38+
height: 24px;
4239
}
4340

4441
.highlighted {
@@ -85,6 +82,6 @@ $_accent: map-get(mat.get-color-config($tb-theme), accent);
8582
// allowed for the tab content. Then the child element can correctly decide when
8683
// a scroll bar is needed. This class is added to a div internal to the
8784
// mat-tab-group.
88-
::ng-deep .mat-tab-body-wrapper {
85+
::ng-deep .mat-mdc-tab-body-wrapper {
8986
flex: 1;
9087
}

tensorboard/webapp/metrics/views/right_pane/settings_view_component.scss

-1
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ mat-slider {
133133
}
134134
}
135135
mat-icon {
136-
width: 15px;
137136
margin-right: 6px;
138137
}
139138
}

0 commit comments

Comments
 (0)