Skip to content

Commit e6baedd

Browse files
authored
MDC Migration: remove padding to individual dialogs in favor of global padding setting (#6690)
## Motivation for features / changes For consistency it would be better to have a global padding setting. The old mat-dialog had a default padding. During migration we added padding to a few components but we missed one. Internally we also have many more dialogs which look broken after migration. The global setting is less code to maintain and gives our dialogs consistency. I added the global setting in #6689 but realized the stacking of the previously added padding during migration made some of the dialogs look bad. ## Screenshots of UI changes (or N/A) ![Screenshot 2023-12-01 at 3 38 31 PM](https://github.com/tensorflow/tensorboard/assets/8672809/bc288a0d-e495-4a0d-bad7-e7600ddbc916) <img width="427" alt="Screenshot 2023-12-04 at 3 00 08 PM" src="https://github.com/tensorflow/tensorboard/assets/8672809/524ec2c4-3d66-49ef-a681-4cb26c5cab56"> ![Screenshot 2023-12-01 at 3 40 41 PM](https://github.com/tensorflow/tensorboard/assets/8672809/9d417abb-4103-4d82-bec8-38dc475f7f34)
1 parent 52304a6 commit e6baedd

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_component.scss

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ $padding-size: 16px;
2828
@include tb-theme-foreground-prop(color, link-visited);
2929
}
3030
}
31-
padding: $padding-size;
31+
padding-bottom: $padding-size;
3232
}
3333

3434
.group-container {
35-
margin: $padding-size;
35+
margin: $padding-size 0;
3636

3737
h4 {
3838
margin-bottom: $padding-size;

tensorboard/webapp/settings/_views/settings_dialog_component.css

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,11 @@ limitations under the License.
1717
}
1818

1919
:host > div {
20-
margin: 16px;
20+
margin: 16px 0;
2121
}
2222

2323
h3 {
2424
font-size: 20px;
25-
margin: 16px;
2625
}
2726

2827
.reload-toggle {

tensorboard/webapp/theme/_tb_theme.template.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ $tb-dark-theme: map_merge(
287287
// new dialog this padding was added to avoid adding it to them all
288288
// individually.
289289
.mat-mdc-dialog-surface {
290-
padding: 24px;
290+
padding: 16px;
291291
}
292292
}
293293

0 commit comments

Comments
 (0)