Skip to content

Commit 339d7ce

Browse files
authored
Merge pull request #274 from testcontainers/fix-dockerfile-resource-leak
Ensure that piped streams are closed automatically
2 parents 638e4d0 + dc1b260 commit 339d7ce

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

core/src/main/java/org/testcontainers/images/builder/ImageFromDockerfile.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.github.dockerjava.api.model.BuildResponseItem;
77
import com.github.dockerjava.core.command.BuildImageResultCallback;
88
import com.google.common.collect.Sets;
9+
import lombok.Cleanup;
910
import lombok.Getter;
1011
import lombok.extern.slf4j.Slf4j;
1112
import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
@@ -113,8 +114,8 @@ public void onNext(BuildResponseItem item) {
113114
};
114115

115116
// We have to use pipes to avoid high memory consumption since users might want to build really big images
116-
PipedInputStream in = new PipedInputStream();
117-
PipedOutputStream out = new PipedOutputStream(in);
117+
@Cleanup PipedInputStream in = new PipedInputStream();
118+
@Cleanup PipedOutputStream out = new PipedOutputStream(in);
118119

119120
profiler.start("Configure image");
120121
BuildImageCmd buildImageCmd = dockerClient.buildImageCmd(in);

0 commit comments

Comments
 (0)