Skip to content

Commit d35fb61

Browse files
committed
comments addressed
1 parent 7161e3f commit d35fb61

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

modules/oceanbase-ce/src/main/java/org/testcontainers/containers/OceanBaseContainer.java

+4-12
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,15 @@ public class OceanBaseContainer extends JdbcDatabaseContainer<OceanBaseContainer
2222

2323
static final String DOCKER_IMAGE_NAME = "oceanbase/oceanbase-ce";
2424

25-
static final String DEFAULT_TAG = "4.1.0.0";
26-
2725
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse(DOCKER_IMAGE_NAME);
2826

2927
private static final Integer SQL_PORT = 2881;
3028

3129
private static final Integer RPC_PORT = 2882;
3230

33-
private final String databaseName;
34-
35-
private final String username;
36-
37-
private final String password;
31+
private final String databaseName = "test";
32+
private final String username = "root@test";
33+
private final String password = "";
3834

3935
public OceanBaseContainer(String dockerImageName) {
4036
this(DockerImageName.parse(dockerImageName));
@@ -44,11 +40,7 @@ public OceanBaseContainer(DockerImageName dockerImageName) {
4440
super(dockerImageName);
4541
dockerImageName.assertCompatibleWith(DEFAULT_IMAGE_NAME);
4642

47-
this.databaseName = "test";
48-
this.username = "root@test";
49-
this.password = "";
50-
51-
this.waitStrategy = Wait.forLogMessage(".*boot success!.*", 1).withStartupTimeout(Duration.ofMinutes(5));
43+
this.waitStrategy = Wait.forLogMessage(".*boot success!.*", 1).withStartupTimeout(Duration.ofMinutes(3));
5244

5345
addExposedPorts(SQL_PORT, RPC_PORT);
5446
}

modules/oceanbase-ce/src/main/java/org/testcontainers/containers/OceanBaseContainerProvider.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,16 @@
77
*/
88
public class OceanBaseContainerProvider extends JdbcDatabaseContainerProvider {
99

10+
private static final String DEFAULT_TAG = "4.1.0.0";
11+
1012
@Override
1113
public boolean supports(String databaseType) {
1214
return databaseType.equals(OceanBaseContainer.NAME);
1315
}
1416

1517
@Override
1618
public JdbcDatabaseContainer newInstance() {
17-
return newInstance(OceanBaseContainer.DEFAULT_TAG);
19+
return newInstance(DEFAULT_TAG);
1820
}
1921

2022
@Override

0 commit comments

Comments
 (0)