Skip to content

Commit c10223f

Browse files
committed
Use random names for networks
1 parent 97ad2b8 commit c10223f

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

core/testcontainers/core/network.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,19 @@
1010
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
1111
# License for the specific language governing permissions and limitations
1212
# under the License.
13+
import uuid
1314
from typing import Optional
1415

1516
from testcontainers.core.docker_client import DockerClient
1617

1718

1819
class Network(object):
1920
"""
20-
Network context manager to conveniently connect containers.
21+
Network context manager for programmatically connecting containers.
2122
"""
2223

23-
def __init__(self, name, docker_client_kw: Optional[dict] = None, **kwargs) -> None:
24-
self.name = name
24+
def __init__(self, docker_client_kw: Optional[dict] = None, **kwargs) -> None:
25+
self.name = str(uuid.uuid4())
2526
self._docker = DockerClient(**(docker_client_kw or {}))
2627
self._kwargs = kwargs
2728

core/tests/test_network.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44

55

66
def test_network_gets_created_and_cleaned_up():
7-
with Network("test-network") as network:
7+
with Network() as network:
88
docker = DockerClient()
9-
networks_list = docker.client.networks.list("test-network")
10-
assert networks_list[0].name == "test-network"
9+
networks_list = docker.client.networks.list(network.name)
10+
assert networks_list[0].name == network.name
1111
assert networks_list[0].id == network.id
12-
assert not docker.client.networks.list("test-network")
12+
assert not docker.client.networks.list(network.name)
1313

1414

1515
def test_containers_can_communicate_over_network():
16-
with Network("network") as network:
16+
with Network() as network:
1717
with DockerContainer("nginx:alpine-slim").with_name(
1818
"alpine1").with_kwargs(network=network.name) as alpine1:
1919
with DockerContainer("nginx:alpine-slim").with_name(

0 commit comments

Comments
 (0)