Skip to content

Commit cd72f68

Browse files
authored
fix: Fix the return type of DockerContainer.get_logs (#487)
1 parent 1d10c1c commit cd72f68

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

core/testcontainers/core/container.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def get_wrapped_container(self) -> "Container":
148148
def get_docker_client(self) -> DockerClient:
149149
return self._docker
150150

151-
def get_logs(self) -> tuple[str, str]:
151+
def get_logs(self) -> tuple[bytes, bytes]:
152152
if not self._container:
153153
raise ContainerStartException("Container should be started before getting logs")
154154
return self._container.logs(stderr=False), self._container.logs(stdout=False)

core/tests/test_core.py

+2
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,6 @@ def test_can_get_logs():
2828
with DockerContainer("hello-world") as container:
2929
wait_for_logs(container, "Hello from Docker!")
3030
stdout, stderr = container.get_logs()
31+
assert isinstance(stdout, bytes)
32+
assert isinstance(stderr, bytes)
3133
assert stdout, "There should be something on stdout"

0 commit comments

Comments
 (0)