Skip to content

fix(security): Update track-modules job #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix(security): Update track-modules job #787

merged 3 commits into from
Mar 17, 2025

Conversation

Tranquility2
Copy link
Contributor

This will address the Security issue reported on #786
As recommended, tj-actions/changed-files was replace replaced with path-filter

@Tranquility2
Copy link
Contributor Author

Tranquility2 commented Mar 15, 2025 •
edited
Loading

Note to reviewer, I keep the testing so we can see it works the same.
Testing locally is limited (I used act)
the final result looks like
[modules/track-modules] ⚙ ::set-output:: computed_modules=["aws","generic"]
which looks compatibale with what we had on (for example) https://github.com/testcontainers/testcontainers-python/actions/runs/13502155079/job/37723003600?pr=778
image

computed_modules=["scylla"]

Tranquility2
Tranquility2 commented Mar 15, 2025
View reviewed changes
.github/workflows/ci-community.yml
dir_names: true
dir_names_exclude_current_dir: true
json: true
base: ${{ github.ref }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was needed locally, we can try without on a later stage

@Tranquility2 Tranquility2 changed the title Track modules update Update track-modules job Mar 15, 2025
@Tranquility2 Tranquility2 changed the title Update track-modules job fix(security): Update track-modules job Mar 15, 2025
mdelapenya
mdelapenya reviewed Mar 17, 2025
View reviewed changes
.github/workflows/ci-community.yml Outdated
- name: Get changed files
id: changed-files
uses: tj-actions/changed-files@v42
uses: dorny/paths-filter@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Can we use the pinned version of v3 (passing the commit hash)?

mdelapenya
mdelapenya reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW the GH action was restored removing the offending commit. In the case we want to keep it, I'd encourage using a pinned version of the action. And if possible, also pin any other GH action

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a0785d7). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage        ?   84.73%           
=======================================
  Files           ?       12           
  Lines           ?      668           
  Branches        ?      105           
=======================================
  Hits            ?      566           
  Misses          ?       79           
  Partials        ?       23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

alexanderankin
alexanderankin approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@alexanderankin alexanderankin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@alexanderankin alexanderankin merged commit f979525 into testcontainers:main Mar 17, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Apr 1, 2025
Merged
alexanderankin pushed a commit that referenced this pull request Apr 2, 2025
@github-actions
chore(main): release testcontainers 4.10.0 (#798)
46feb1e 
🤖 I have created a release *beep* *boop*
---


##
[4.10.0](testcontainers-v4.9.2...testcontainers-v4.10.0)
(2025-04-02)


### Features

* Add SocatContainer
([#795](#795))
([2f9139c](2f9139c))


### Bug Fixes

* **ollama:** make device request a list
([#799](#799))
([9497a45](9497a45))
* **security:** Update track-modules job
([#787](#787))
([f979525](f979525))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya left review comments

@alexanderankin alexanderankin alexanderankin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tranquility2 @mdelapenya @alexanderankin