From 7c639d76dc68d7f6644667e62e95d601e13a083d Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 18:55:52 +0100 Subject: [PATCH 01/25] fix(build): early exit strategy for modules --- modules/README.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 modules/README.md diff --git a/modules/README.md b/modules/README.md new file mode 100644 index 00000000..ca521bf3 --- /dev/null +++ b/modules/README.md @@ -0,0 +1,3 @@ +# Modules + +The modules directory contains all the community-supported containers that see common use cases and merit their own easy-access container. \ No newline at end of file From acefacac9ad6d2a8c003ea7d108b2e962482ba14 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 19:08:57 +0100 Subject: [PATCH 02/25] fix: linting --- modules/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/README.md b/modules/README.md index ca521bf3..012c3f55 100644 --- a/modules/README.md +++ b/modules/README.md @@ -1,3 +1,3 @@ # Modules -The modules directory contains all the community-supported containers that see common use cases and merit their own easy-access container. \ No newline at end of file +The modules directory contains all the community-supported containers that see common use cases and merit their own easy-access container. From 76a0975af1940434a72c815b4241582061c56e05 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 19:33:57 +0100 Subject: [PATCH 03/25] test: try to delete the running job to not show it as failed --- .github/workflows/ci-community.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index b5b1c65f..c0aba26a 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -59,6 +59,8 @@ jobs: # cancel and wait for run to end gh run cancel ${{ github.run_id }} gh run watch ${{ github.run_id }} + # then delete the run so it doesn't show as failed + gh run delete ${{ github.run_id }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Set up Python From 1486adadb76aad06f32db91f3d8c4b6c8b1ff34f Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 20:22:04 +0100 Subject: [PATCH 04/25] fix: set up matrix test after file tracking --- .github/workflows/ci-community.yml | 42 ++++++++++++++---------------- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index c0aba26a..124b6bd3 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -4,23 +4,35 @@ name: modules on: push: - branches: [main] + branches: [ main ] paths: - "modules/**" pull_request: - branches: [main] + branches: [ main ] paths: - "modules/**" -permissions: - actions: write # needed for self-cancellation - jobs: + track-files: + runs-on: ubuntu-latest + steps: + - name: Checkout contents + uses: actions/checkout@v4 + with: + fetch-depth: 0 # recommended by tj-actions/changed-files + - name: Get changed files + id: changes-for-module + uses: tj-actions/changed-files@v42 + with: + files: | + modules/${{ matrix.module }}/** + outputs: + changed_files: ${{ steps.track-files.outputs.all_changed_files }} test: strategy: fail-fast: false matrix: - python-version: ["3.11"] + python-version: [ "3.11" ] module: - arangodb - azurite @@ -44,25 +56,11 @@ jobs: - selenium - k3s runs-on: ubuntu-latest + needs: track-files + if: ${{ contains(needs.track-files.outputs.changed_files, matrix.module) }} steps: - name: Checkout contents uses: actions/checkout@v4 - - name: Get changed files - id: changes-for-module - uses: tj-actions/changed-files@v42 - with: - files: | - modules/${{ matrix.module }}/** - - name: Exit early, nothing to do - if: ${{ steps.changes-for-module.outputs.any_changed == 'false' }} - run: | - # cancel and wait for run to end - gh run cancel ${{ github.run_id }} - gh run watch ${{ github.run_id }} - # then delete the run so it doesn't show as failed - gh run delete ${{ github.run_id }} - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Set up Python uses: ./.github/actions/setup-env with: From 6f185ac255cefd3ad3057d96bca32360646c028e Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:21:06 +0100 Subject: [PATCH 05/25] fix: compute modules with jq --- .github/workflows/ci-community.yml | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 124b6bd3..ec8f0ad9 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -21,13 +21,22 @@ jobs: with: fetch-depth: 0 # recommended by tj-actions/changed-files - name: Get changed files - id: changes-for-module + id: changed-files uses: tj-actions/changed-files@v42 with: - files: | - modules/${{ matrix.module }}/** + path: "./modules" + diff_relative: true + dir_names: true + dir_names_exclude_current_dir: true + json: true + - name: Compute modules from files + id: compute-changes + run: | + modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | nth(1)' | jq -s -c '. | unique') + echo "computed_modules=$modules" + echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: - changed_files: ${{ steps.track-files.outputs.all_changed_files }} + changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} test: strategy: fail-fast: false @@ -56,8 +65,8 @@ jobs: - selenium - k3s runs-on: ubuntu-latest - needs: track-files - if: ${{ contains(needs.track-files.outputs.changed_files, matrix.module) }} + needs: [track-files] + if: ${{ "true" == "false" }} steps: - name: Checkout contents uses: actions/checkout@v4 From c610954e0d0301773484d476de39ffd8d19ea31f Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:23:04 +0100 Subject: [PATCH 06/25] fix: disable test step --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index ec8f0ad9..d9c2cf1d 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -66,7 +66,7 @@ jobs: - k3s runs-on: ubuntu-latest needs: [track-files] - if: ${{ "true" == "false" }} + if: false steps: - name: Checkout contents uses: actions/checkout@v4 From 4ccd985b5305f4f62ef3de3711b08c271657c778 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:27:12 +0100 Subject: [PATCH 07/25] test: touch arangodb for testing --- .github/workflows/ci-community.yml | 24 +----------------------- modules/arangodb/README.rst | 2 ++ 2 files changed, 3 insertions(+), 23 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index d9c2cf1d..8c3bf571 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -42,31 +42,9 @@ jobs: fail-fast: false matrix: python-version: [ "3.11" ] - module: - - arangodb - - azurite - - clickhouse - - elasticsearch - - google - - kafka - - keycloak - - localstack - - minio - - mongodb - - mssql - - mysql - - neo4j - - nginx - - opensearch - - oracle - - postgres - - rabbitmq - - redis - - selenium - - k3s + module: ${{ fromJSON(needs.track-files.outputs.changed_modules) }} runs-on: ubuntu-latest needs: [track-files] - if: false steps: - name: Checkout contents uses: actions/checkout@v4 diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 7f2837f2..4c312fcb 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1 +1,3 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer + +some extra text From 0a0268bd3739658c4d1affd566b2eb9713238ca8 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:30:10 +0100 Subject: [PATCH 08/25] fix: diff_relative does not include the dot --- .github/workflows/ci-community.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 8c3bf571..580d4e3c 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -32,19 +32,19 @@ jobs: - name: Compute modules from files id: compute-changes run: | - modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | nth(1)' | jq -s -c '. | unique') + modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | first' | jq -s -c '. | unique') echo "computed_modules=$modules" echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} test: + needs: [track-files] strategy: fail-fast: false matrix: python-version: [ "3.11" ] module: ${{ fromJSON(needs.track-files.outputs.changed_modules) }} runs-on: ubuntu-latest - needs: [track-files] steps: - name: Checkout contents uses: actions/checkout@v4 From ba7e9c25e8026d9c5e77e02f39b529625976d400 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:34:34 +0100 Subject: [PATCH 09/25] fix: only kick off test job when there is anything to do --- .github/workflows/ci-community.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 580d4e3c..4c230519 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -13,7 +13,7 @@ on: - "modules/**" jobs: - track-files: + track-modules: runs-on: ubuntu-latest steps: - name: Checkout contents @@ -37,13 +37,15 @@ jobs: echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} + any_changed: ${{ steps.changed-files.outputs.any_changes }} test: - needs: [track-files] + needs: [track-modules] + if: ${{ needs.track-modules.outputs.any_changed == "true" }} strategy: fail-fast: false matrix: python-version: [ "3.11" ] - module: ${{ fromJSON(needs.track-files.outputs.changed_modules) }} + module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} runs-on: ubuntu-latest steps: - name: Checkout contents From 1ae7ba4239c4522da46da74726debd26ba08593e Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:35:40 +0100 Subject: [PATCH 10/25] fix: typo --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 4c230519..88926cbb 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -40,7 +40,7 @@ jobs: any_changed: ${{ steps.changed-files.outputs.any_changes }} test: needs: [track-modules] - if: ${{ needs.track-modules.outputs.any_changed == "true" }} + if: ${{ needs.track-modules.outputs.any_changed == 'true' }} strategy: fail-fast: false matrix: From dd792d8d8cc2d28d23d311731f4f3613a56de153 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:37:30 +0100 Subject: [PATCH 11/25] fix: typo --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 88926cbb..a4b22722 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -37,7 +37,7 @@ jobs: echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} - any_changed: ${{ steps.changed-files.outputs.any_changes }} + any_changed: ${{ steps.changed-files.outputs.any_changed }} test: needs: [track-modules] if: ${{ needs.track-modules.outputs.any_changed == 'true' }} From c5e877806bbb390b8e9bef07dc5aa09b8b209ca6 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:40:23 +0100 Subject: [PATCH 12/25] fix: keep it simple --- .github/workflows/ci-community.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index a4b22722..a9d57a3e 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -37,10 +37,8 @@ jobs: echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} - any_changed: ${{ steps.changed-files.outputs.any_changed }} test: needs: [track-modules] - if: ${{ needs.track-modules.outputs.any_changed == 'true' }} strategy: fail-fast: false matrix: From 5321245667d4ddb01519044636b074917f00b328 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:41:57 +0100 Subject: [PATCH 13/25] revert: no more arangodb changes --- modules/arangodb/README.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 4c312fcb..7f2837f2 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1,3 +1 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer - -some extra text From 0dfabace6a8cc22be3a6d2fc086b293734788063 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:51:17 +0100 Subject: [PATCH 14/25] fix: count the modules for the test job --- .github/workflows/ci-community.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index a9d57a3e..9a5ad48d 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -33,10 +33,14 @@ jobs: id: compute-changes run: | modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | first' | jq -s -c '. | unique') + count=$(echo $modules | jq '. | length') echo "computed_modules=$modules" + echo "module_count=$count" echo "computed_modules=$modules" >> $GITHUB_OUTPUT + echo "module_count=$count" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} + changed_module_count: ${{ steps.compute-changes.outputs.module_count }} test: needs: [track-modules] strategy: @@ -44,6 +48,7 @@ jobs: matrix: python-version: [ "3.11" ] module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} + if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) > 0 }} runs-on: ubuntu-latest steps: - name: Checkout contents From 43c511966876d5121514e4edffcebd41c2b57ba3 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:52:10 +0100 Subject: [PATCH 15/25] test: touch arangodb --- modules/arangodb/README.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 7f2837f2..6be9fc21 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1 +1,2 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer +.arangodb From 5111c6f27493032feb2ee14d4203209445bc8684 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:54:06 +0100 Subject: [PATCH 16/25] fix: docs are failing other jobs --- modules/arangodb/README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 6be9fc21..41dd4578 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1,2 +1,2 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer -.arangodb +toto From df6339d9a59e73fdf2e88d652c45c5dbc1e1d67e Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:56:22 +0100 Subject: [PATCH 17/25] test: try falsy/truthy values for if --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 9a5ad48d..569e2d33 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -48,7 +48,7 @@ jobs: matrix: python-version: [ "3.11" ] module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} - if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) > 0 }} + if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} runs-on: ubuntu-latest steps: - name: Checkout contents From 9d78351e98b95ee526d0f33ee8377393b1b26d01 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 22:58:15 +0100 Subject: [PATCH 18/25] revert: no more arangodb, testing 'no module' scenario --- modules/arangodb/README.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 41dd4578..7f2837f2 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1,2 +1 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer -toto From 1c86a0fe21df190356fc356df01b5ba7d6122fbc Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:01:14 +0100 Subject: [PATCH 19/25] fix: formatting --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 569e2d33..2113f6c3 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -43,12 +43,12 @@ jobs: changed_module_count: ${{ steps.compute-changes.outputs.module_count }} test: needs: [track-modules] + if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} strategy: fail-fast: false matrix: python-version: [ "3.11" ] module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} - if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} runs-on: ubuntu-latest steps: - name: Checkout contents From be8897bc82372b8f7494a516026844a4df6179b2 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:07:26 +0100 Subject: [PATCH 20/25] test: include-matrix --- .github/workflows/ci-community.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 2113f6c3..b8d20f95 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -34,21 +34,21 @@ jobs: run: | modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | first' | jq -s -c '. | unique') count=$(echo $modules | jq '. | length') + matrix=$(echo $modules | jq '.[] | { module: . }' | jq -s -c '{ include: . }') echo "computed_modules=$modules" echo "module_count=$count" echo "computed_modules=$modules" >> $GITHUB_OUTPUT echo "module_count=$count" >> $GITHUB_OUTPUT + echo "matrix=$matrix" >> $GITHUB_OUTPUT outputs: + matrix: ${{ steps.compute-changes.outputs.matrix }} changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} changed_module_count: ${{ steps.compute-changes.outputs.module_count }} test: needs: [track-modules] - if: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} strategy: fail-fast: false - matrix: - python-version: [ "3.11" ] - module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} + matrix: ${{ fromJSON(needs.track-modules.outputs.matrix) }} runs-on: ubuntu-latest steps: - name: Checkout contents From 1e7962dd29da6774a8d417938195b80a3994ee16 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:11:26 +0100 Subject: [PATCH 21/25] revert: keep it simple --- .github/workflows/ci-community.yml | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index b8d20f95..6ceed20a 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -33,22 +33,18 @@ jobs: id: compute-changes run: | modules=$(echo "${{ steps.changed-files.outputs.all_changed_files }}" | jq '.[] | split("/") | first' | jq -s -c '. | unique') - count=$(echo $modules | jq '. | length') - matrix=$(echo $modules | jq '.[] | { module: . }' | jq -s -c '{ include: . }') echo "computed_modules=$modules" - echo "module_count=$count" echo "computed_modules=$modules" >> $GITHUB_OUTPUT - echo "module_count=$count" >> $GITHUB_OUTPUT - echo "matrix=$matrix" >> $GITHUB_OUTPUT outputs: - matrix: ${{ steps.compute-changes.outputs.matrix }} changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} changed_module_count: ${{ steps.compute-changes.outputs.module_count }} test: needs: [track-modules] strategy: fail-fast: false - matrix: ${{ fromJSON(needs.track-modules.outputs.matrix) }} + matrix: + python-version: [ "3.11" ] + module: ${{ fromJSON(needs.track-modules.outputs.changed_modules) }} runs-on: ubuntu-latest steps: - name: Checkout contents From 53035cb12e16a9dea7b525469fe3a6438996a7d1 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:14:35 +0100 Subject: [PATCH 22/25] fix: follow GH community recommendation on if --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 6ceed20a..6dd11ccb 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -37,9 +37,9 @@ jobs: echo "computed_modules=$modules" >> $GITHUB_OUTPUT outputs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} - changed_module_count: ${{ steps.compute-changes.outputs.module_count }} test: needs: [track-modules] + if: ${{ needs.track-modules.outputs.changed_modules != "[]" }} strategy: fail-fast: false matrix: From 477dc469f0c97389507678d294e81ca51b3b1221 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:15:49 +0100 Subject: [PATCH 23/25] fix: typo --- .github/workflows/ci-community.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-community.yml b/.github/workflows/ci-community.yml index 6dd11ccb..5188b9d4 100644 --- a/.github/workflows/ci-community.yml +++ b/.github/workflows/ci-community.yml @@ -39,7 +39,7 @@ jobs: changed_modules: ${{ steps.compute-changes.outputs.computed_modules }} test: needs: [track-modules] - if: ${{ needs.track-modules.outputs.changed_modules != "[]" }} + if: ${{ needs.track-modules.outputs.changed_modules != '[]' }} strategy: fail-fast: false matrix: From 7d5aed7b7fca1a33c6a1fa63e6d62c2b7dccdf42 Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:16:43 +0100 Subject: [PATCH 24/25] test: arangodb enabled again --- modules/arangodb/README.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index 7f2837f2..f22ab41e 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1 +1,2 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer +testing From 69d3507e2549d16d49f907dcb0d926b38f2c7b0a Mon Sep 17 00:00:00 2001 From: Balint Bartha <39852431+totallyzen@users.noreply.github.com> Date: Fri, 1 Mar 2024 23:17:54 +0100 Subject: [PATCH 25/25] revert: no more arangodb --- modules/arangodb/README.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/arangodb/README.rst b/modules/arangodb/README.rst index f22ab41e..7f2837f2 100644 --- a/modules/arangodb/README.rst +++ b/modules/arangodb/README.rst @@ -1,2 +1 @@ .. autoclass:: testcontainers.arangodb.ArangoDbContainer -testing