Skip to content

Commit ab6d90f

Browse files
authored
fix(allByLabelText): forEach on NodeList is not supported in edge (#463)
1 parent 6bb57a9 commit ab6d90f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Diff for: src/queries/label-text.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,19 @@ function queryAllByLabelText(
6464
}
6565
if (label.getAttribute('id')) {
6666
// <label id="someId">text</label><input aria-labelledby="someId" />
67-
container
68-
.querySelectorAll(`[aria-labelledby~="${label.getAttribute('id')}"]`)
69-
.forEach(element => elementsForLabel.push(element))
67+
Array.from(
68+
container.querySelectorAll(
69+
`[aria-labelledby~="${label.getAttribute('id')}"]`,
70+
),
71+
).forEach(element => elementsForLabel.push(element))
7072
}
7173
if (label.childNodes.length) {
7274
// <label>text: <input /></label>
7375
const formControlSelector =
7476
'button, input, meter, output, progress, select, textarea'
75-
label
76-
.querySelectorAll(formControlSelector)
77-
.forEach(element => elementsForLabel.push(element))
77+
Array.from(
78+
label.querySelectorAll(formControlSelector),
79+
).forEach(element => elementsForLabel.push(element))
7880
}
7981
return matchedElements.concat(elementsForLabel)
8082
}, [])

0 commit comments

Comments
 (0)