fix(prefer-in-document): check that a node has arguments before trying to access properties on them #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
commented
Apr 23, 2021
benmonro
approved these changes
Apr 23, 2021
|
@all-contributors please add @G-Rath for tests, code, bugs |
|
I've put up a pull request to add @G-Rath! 🎉 |
|
@G-Rath thanks for finding & fixing this! |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 381 383 +2
Branches 69 69
=========================================
+ Hits 381 383 +2
Continue to review full report at Codecov.
|
|
@benmonro I've got some more fixes of this nature, which I'll push into this PR. |
|
@G-Rath sounds good just let me know when to merge |
G-Rath
force-pushed
the
fix-length-check
branch
from
3f00a90 to
228e760
Compare
|
@benmonro this one should be good to go now. |
G-Rath
changed the title
toHaveLength without arguments
benmonro
approved these changes
Apr 24, 2021
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
It seems that
prefer-in-documentcrashes in situations where it expected nodes to have an argument but they actually don't.Why:
The rule assumes that if it's found the node its looking for, then the node has to have arguments and so makes property access keys in the first item in the args array without actually checking if its defined.
How:
I've added checks for the argument length before attempts to access said arguments.
Checklist: