fix(createBannedAttributeRule): check arguments length before accessing #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmonro
approved these changes
Apr 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 383 386 +3
Branches 69 71 +2
=========================================
+ Hits 383 386 +3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
It seems that
createBannedAttributeRulecrashes in situations where it expected nodes to have an argument but they actually don't.Why:
The function assumes that if it's found the node its looking for, then the node has to have arguments and so makes property access keys in the first item in the args array without actually checking if its defined.
How:
I added a length check on the arguments the matcher has.
Checklist:
Fixes #127