feat: [prefer-in-document] Detect and auto-fix toBeFalsy() and toBeTruthy()
#172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 15 15
Lines 386 555 +169
Branches 71 152 +81
==========================================
+ Hits 386 555 +169
Continue to review full report at Codecov.
|
|
|
julienw
changed the title
toBeFalsy() and toBeTruthy()toBeFalsy() and toBeTruthy()
julienw
force-pushed
the
detect-to-falsy-prefer-in-document
branch
from
b48bcd0 to
2355682
Compare
julienw
force-pushed
the
detect-to-falsy-prefer-in-document
branch
from
2355682 to
845a1d6
Compare
|
Looks like you need to update the required checks in github :-) |
|
thanks again @julienw |
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Autofix
toBeFalsy()tonot.toBeInTheDocument()andtoBeTruthy()totoBeInTheDocument().Why: I noticed in our test code an occurrence of
expect(queryByText(XXX)).toBeFalsy()which I think should be detected by this plugin.How: I merely updated existing code.
Checklist: