fix(prefer-to-have-attribute): Handle case where matcher value is empty string #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty string value This change purposefully treats an empty string value for certain matchers as value instead of as null. Prior to this change, the fixer was incorrectly inferring a .not. Matchers affected are: - toBe - toStrictEqual - toEqual
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 555 555
Branches 152 152
=========================================
Hits 555 555
Continue to review full report at Codecov.
|
|
@all-contributors add @mdotwills for bugs, code |
|
I've put up a pull request to add @mdotwills! 🎉 |
|
🎉 This PR is included in version 3.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Bugfix to handle case where in circumstances that the matcher value has been intended as an empty string, the fixer incorrectly assumes the
.notcase.Why:
The purpose of this fix is so that the code fixer can correctly match empty string attributes as differentiated from null or missing values.
How:
Do not treat an empty string as a null value.
Checklist:
Feel free to merge if approved.