Skip to content

fix: Publish built source #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 12, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 12, 2021

What:

Closes #194

Why:

Release workflow no longer built files after 48b7e2b. The commit was pushed without a PR for some reason. Unclear why since PRs are a vital tool to ensure changes are peer reviewed.

How:

Restore steps from https://github.com/testing-library/eslint-plugin-jest-dom/blob/eac998edba29debec7dda1257e3fbe3dbdf10fef/.github/workflows/eslint-plugin-jest-dom.yml that were not ported to https://github.com/testing-library/eslint-plugin-jest-dom/blob/48b7e2b44e1310991de677dc1981fc748d46c4ee/.github/workflows/validate.yml

Checklist:

  • [ ] Documentation
  • [ ] Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #195 (32da876) into main (48b7e2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          555       555           
  Branches       152       152           
=========================================
  Hits           555       555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48b7e2b...32da876. Read the comment docs.

@eps1lon eps1lon merged commit 8c84f14 into testing-library:main Sep 12, 2021
@eps1lon eps1lon deleted the fix/release branch September 12, 2021 08:58
@github-actions
Copy link

🎉 This PR is included in version 3.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3.9.1 does not include the compiled code
1 participant