Dependency on @testing-library/dom

[eps1lon]

It's not apparent from the documentation why this plugin has a dependency on @testing-library/dom.

It looks like it does some branching based on whether a query is a DTL query or not but I can't find documentation how this affects rules in this repo.

This would help asses if we need a direct runtime dependency (current) or peer dependency or configuration option instead i.e. instead of requiring DTL and getting the list of queries, the user inputs that list.

Documenting this internal behavior would help to understand if custom queries should also be considered.

Ideally there wouldn't be a dependency on /dom at all so that users just have to update /dom if that releases a major and not update /dom and eslint-plugin-jest-dom. jest-dom doesn't have a dependency on /dom after all.

[ctjhoa]

Completely agree on that, I struggled to find why I had many React act warning (testing-library/react-testing-library#1051) to finally see that there was a mismatch between @testing-library/dom required by eslint-plugin-jest-dom and @testing-library/react

[cbookg]

I had to remove this plugin in order to upgrade to React 18. It would be nice to be able to add it back.

[ctjhoa]

@cbookg You can use yarn resolutions or npm overrides to continue to use this plugin but not really a long term solution.
eg.

  "resolutions": {
    "@testing-library/dom": "^9.0.0",
  },

[github-actions]

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀