jest-dom/prefer-empty wrong detection, and wrong fix.

[RIP21]

• eslint-plugin-jest-dom version: 3.0.1
• node version: 12.16.1
• npm version: 6.13.4

Broken fix and detection
This is detected as error

const DONT_KNOW_TEXT = "Don't know"
expect(textarea.innerHTML).toBe(DONT_KNOW_TEXT)

Fixes to

expect(textarea).toBeEmpty()

[benmonro]

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[benmonro]

@all-contributors please add @RIP21 for bugs

[allcontributors]

@benmonro

I've put up a pull request to add @RIP21! 🎉

[benmonro]

@RIP21 I believe all of the issues you reported should be fixed now. Mind confirming in the latest release? Much appreciation for the issues you reported and all the great examples, I was able to use them for the tests...

[RIP21]

@benmonro awesome. Thank you very much! You're legend :) I'll update on Monday and see how it goes :)

[atsikov]

@benmonro I'm afraid this is not fully fixed. Template strings are not properly handled.

expect(statusText.innerHTML).toBe(`${value}%`)

Still pops up as an error

[benmonro]

@atsikov thank you for reporting, I hadn't considered that use case. will have a fix published shortly

[benmonro]

@atsikov fix released in 3.1.6 can you please update and let me know if it fixes your issue and/or any other issues I may have missed? many thanks -Ben

[atsikov]

Wow @benmonro that was fast! 🚀
Thanks a lot, templates with params are now treated as non-empty values.

However it still shows an error in case template doesn't have params.
Sure it's not a common case, but probably worth fixing as well.

expect(statusText.innerHTML).toBe(`Complete`) // note backticks

[benmonro]

ah yeah ok that actually might take a bit more work, will have to look at that tonight, as a work around you can use ' or " for now.

[benmonro]

@atsikov sorry for the delay, 3.1.7 should address your issue, but please do let me know if you find another!