Skip to content

fix: better handling of template literals #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

benmonro
Copy link
Member

@benmonro benmonro commented Sep 1, 2020

What: ensure better handling of template literals

Why: so you don't get undefined in fixers

How: using context.getSourceCode().getText(node)

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          183       184    +1     
  Branches        21        21           
=========================================
+ Hits           183       184    +1     
Impacted Files Coverage Δ
src/rules/prefer-to-have-style.js 100.00% <ø> (ø)
src/rules/prefer-empty.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7547a54...5c8c343. Read the comment docs.

@benmonro benmonro merged commit d639db4 into master Sep 1, 2020
@benmonro benmonro deleted the feature/template-variable-in-styles branch September 1, 2020 15:07
@benmonro
Copy link
Member Author

benmonro commented Sep 1, 2020

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant