fix: add custom element support to toBeDisabled

astorije · web-flow · commit e41eb9dca2bc · 2021-05-21T23:41:45.000+03:00
diff --git a/src/to-be-disabled.js b/src/to-be-disabled.js
@@ -36,8 +36,17 @@ function isElementDisabledByParent(element, parent) {
   )
 }
 
+function isCustomElement(tag) {
+  return tag.includes('-')
+}
+
+/*
+ * Only certain form elements and all custom elements can actually be disabled:
+ * https://html.spec.whatwg.org/multipage/semantics-other.html#disabled-elements
+ */
 function canElementBeDisabled(element) {
-  return FORM_TAGS.includes(getTag(element))
+  const tag = getTag(element)
+  return FORM_TAGS.includes(tag) || isCustomElement(tag)
 }
 
 function isElementDisabled(element) {

Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,17 @@ function isElementDisabledByParent(element, parent) {`
`36`	`36`	`)`
`37`	`37`	`}`
`38`	`38`
	`39`	`+function isCustomElement(tag) {`
	`40`	`+ return tag.includes('-')`
	`41`	`+}`
	`42`	`+`
	`43`	`+/*`
	`44`	`+ * Only certain form elements and all custom elements can actually be disabled:`
	`45`	`+ * https://html.spec.whatwg.org/multipage/semantics-other.html#disabled-elements`
	`46`	`+ */`
`39`	`47`	`function canElementBeDisabled(element) {`
`40`		`- return FORM_TAGS.includes(getTag(element))`
	`48`	`+ const tag = getTag(element)`
	`49`	`+ return FORM_TAGS.includes(tag) \|\| isCustomElement(tag)`
`41`	`50`	`}`
`42`	`51`
`43`	`52`	`function isElementDisabled(element) {`