Skip to content

Suggest not to lock @types/react #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
foray1010 opened this issue Jun 22, 2019 · 1 comment · Fixed by #105
Closed

Suggest not to lock @types/react #104

foray1010 opened this issue Jun 22, 2019 · 1 comment · Fixed by #105
Labels
question Further information is requested

Comments

@foray1010
Copy link
Contributor

What is your question:

as this library locked version of @types/react, I expect we will keep seeing this kind of error as @types/react export global type
Screen Shot 2019-06-22 at 8 42 45 AM

It will be very annoying cause user need to sync the @types/react version with this library in order to avoid this error

could we use ^16.8.22 instead?
@foray1010 foray1010 added the question Further information is requested label Jun 22, 2019
@mpeyper
Copy link
Member

mpeyper commented Jun 22, 2019

Yes. Can you make a PR to fix please.

@foray1010 foray1010 mentioned this issue Jun 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not pin @types/react
2 participants
@foray1010 @mpeyper