Skip to content

Missing typing for cleanup #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Quadriphobs1 opened this issue Oct 25, 2019 · 1 comment
Closed

Missing typing for cleanup #205

Quadriphobs1 opened this issue Oct 25, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Quadriphobs1
Copy link

  • react-hooks-testing-library ^3:
  • react-test-renderer version:
  • react ^16.9:
  • node ^11:

What you did:

Trying to implement cleanup manually in a typescript project but the types definition @types/testing-library__react-hooks doesn't include the cleanup in the exported types.

Suggested solution:

Include typings in the package internally and aviod the use of DefinitelyTyped by that the package would be having an update typings and there will be no need to update on DefinitelyTyped everytime the API changes

@Quadriphobs1 Quadriphobs1 added the bug Something isn't working label Oct 25, 2019
@mpeyper
Copy link
Member

mpeyper commented Oct 25, 2019

Hi @Quadriphobs1,

Moving the types to DefinitelyTyped was a deliberate decision to alleviate issues we were having with type dependencies for our peer dependencies and to allow the typescript community take a more active role in maintaining the types themselves (I am not a typescript user myself) and not have to actively maintain them ourselves.

Please raise an issue in the DefinitelyTyped repo and consider contributing the types yourself. I'm happy to review a PR over there to add them.

@mpeyper mpeyper closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants