Skip to content

TypeScript Typings #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrianMitchL opened this issue Feb 25, 2019 · 3 comments
Closed

TypeScript Typings #7

BrianMitchL opened this issue Feb 25, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BrianMitchL
Copy link

React Testing Library ships with TypeScript types, and when moving to use renderHook from this react-hooks-testing-library, there are no types declared.

This seems like the types could mostly be re-exported from react-testing-library, and pull in what it had for testHook before removing it in v6.0.0: testing-library/react-testing-library@12d934a#diff-494415c3af35245ecae73f5d42d8b331L55
@mpeyper
Copy link
Member

mpeyper commented Feb 25, 2019 •
edited
Loading

Other than the rename from testHook (which also still exists) to renderHook, there has also been a new option added (initialProps) and a parameter added to rerender (newProps).

Happy for someone to contribute these.

@mpeyper mpeyper added enhancement New feature or request good first issue Good for newcomers labels Feb 26, 2019
@otofu-square
Copy link
Contributor

Can I work on this issue? 😄

@mpeyper
Copy link
Member

mpeyper commented Feb 28, 2019

Absolutely!

@otofu-square otofu-square mentioned this issue Feb 28, 2019
Merged
3 tasks
@mpeyper mpeyper closed this as completed in #8 Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrianMitchL @otofu-square @mpeyper