Skip to content

Commit d32b389

Browse files
committed
create a new promise to execute the resolve in order
1 parent bca1ab9 commit d32b389

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-translator",
3-
"version": "3.1.0",
3+
"version": "3.1.1",
44
"description": "A translate-service, translate-pipe and translate-component for angular2",
55
"repository": {
66
"type": "git",

src/Translator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class Translator {
9292
return Promise.reject("Language " + arguments[0] + " not provided");
9393
}
9494

95-
return this.loadLanguage(language);
95+
return new Promise((resolve, reject) => this.loadLanguage(language).then(resolve, reject));
9696
}
9797

9898
/**

tests/Translator.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,15 +277,15 @@ describe("Translator", () => {
277277
expect(JasmineHelper.calls(translationLoader.load).count()).toBe(1);
278278
});
279279

280-
it("returns the already resolved promise", fakeAsync(() => {
280+
it("returns the a new already resolved promise", fakeAsync(() => {
281281
let firstPromise = translator.waitForTranslation();
282282
loaderPromiseResolve({ TEXT: "This is a text" });
283283
JasminePromise.flush();
284284

285285
let secondPromise = translator.waitForTranslation();
286286

287287
expect(secondPromise).toBeResolved();
288-
expect(secondPromise).toBe(firstPromise);
288+
expect(secondPromise).not.toBe(firstPromise);
289289
}));
290290

291291
it("loads given language", () => {

0 commit comments

Comments
 (0)