Skip to content

Commit f10e8e4

Browse files
snoggetgross35
authored andcommitted
ci: Always upload successfully created artifacts
The `Create I artifacts` step is always run, whether earlier steps succeeds or not. But the upload step would only run if all preceeding steps wer successfull. Add a conditional to always run except if artifact creation failed.
1 parent 84a04a1 commit f10e8e4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/ci.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,11 @@ jobs:
122122
run: ./ci/run-docker.sh ${{ matrix.target }}
123123

124124
- name: Create CI artifacts
125+
id: create_artifacts
125126
if: always()
126127
run: ./ci/create-artifacts.py
127128
- uses: actions/upload-artifact@v4
129+
if: always() && steps.create_artifacts.outcome == 'success'
128130
with:
129131
name: ${{ env.ARCHIVE_NAME }}-${{ matrix.target }}
130132
path: ${{ env.ARCHIVE_PATH }}
@@ -191,9 +193,11 @@ jobs:
191193
run: ./ci/run-docker.sh ${{ matrix.target }}
192194

193195
- name: Create CI artifacts
196+
id: create_artifacts
194197
if: always()
195198
run: ./ci/create-artifacts.py
196199
- uses: actions/upload-artifact@v4
200+
if: always() && steps.create_artifacts.outcome == 'success'
197201
with:
198202
name: ${{ env.ARCHIVE_NAME }}-${{ matrix.target }}
199203
path: ${{ env.ARCHIVE_PATH }}

0 commit comments

Comments
 (0)