Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT add feature flag for 'promql-experimental-functions'. #7640

Open
AL82082 opened this issue Aug 14, 2024 · 5 comments · May be fixed by #8191
Open

FT add feature flag for 'promql-experimental-functions'. #7640

AL82082 opened this issue Aug 14, 2024 · 5 comments · May be fixed by #8191

Comments

@AL82082
Copy link

AL82082 commented Aug 14, 2024

Is your proposal related to a problem?

I can't use sort_by_label promql experimental function in thanos-query to sort results by a label, e.g. "environment", where the values are like "dev", "qa", "uat".

This is needed to display results in Grafana Stat panel in a logical ordering.

Describe the solution you'd like

I would like to be able to provide a feature flag argument to the thanos docker image which enables promql experimental functions (sort_by_label, sort_by_label_desc, ...).

Describe alternatives you've considered

I can't add my prometheus instance as a separate Grafana Datasource, or an endpoint in thanos-query, because all of my long-term metrics are coming from S3 via thanos-store.

Additional context

Please see Issue #4022 or PR #4786 for an example of adding feature flag support.

@yeya24
Copy link
Contributor

yeya24 commented Aug 14, 2024

How does this work with the new engine? @MichaHoffmann @fpetkovski Does the new engine support those experimental functions

@MichaHoffmann
Copy link
Contributor

MichaHoffmann commented Aug 14, 2024

How does this work with the new engine? @MichaHoffmann @fpetkovski Does the new engine support those experimental functions

Not yet but at least those sorting functions should be very easy to add!

Edit: something like this: thanos-io/promql-engine#481 ?

@AL82082
Copy link
Author

AL82082 commented Aug 15, 2024

I appreciate the speedy response!

@yeya24
Copy link
Contributor

yeya24 commented Nov 10, 2024

We still need to add a feature flag for promql-experimental-functions. Help wanted.

@heysujal
Copy link

heysujal commented Jan 9, 2025

Hi @yeya24 , I have never worked on adding a feature flag before and would like to pick this up.

@heysujal heysujal linked a pull request Apr 5, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants