Skip to content

Button with a label #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
PadowYT2 opened this issue Sep 29, 2023 · 4 comments
Closed
2 tasks done

Button with a label #1020

PadowYT2 opened this issue Sep 29, 2023 · 4 comments
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers

Comments

@PadowYT2
Copy link

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Steps to reproduce

  1. Make a button
  2. Assign a label

Current behavior

The label doesn't exist on the button

Expected behavior

The label should be added to the button

Context

https://www.flowbite-react.com/docs/components/button#button-with-label

@rluders
Copy link
Collaborator

rluders commented Sep 29, 2023

The issue is probably here:

Please, introduce a unit test to cover the scenario to avoid future regressions.

@rluders rluders added 🐛 bug Something isn't working good first issue Good for newcomers confirmed This bug was confirmed labels Sep 29, 2023
@MateoWartelle
Copy link
Contributor

The issue is probably here:

Please, introduce a unit test to cover the scenario to avoid future regressions.

If both children and label are set what should happen?

<Button label="2"> Messages </Button>

@rluders
Copy link
Collaborator

rluders commented Sep 30, 2023

https://flowbite.com/docs/components/buttons/#button-with-label

This was referenced Sep 30, 2023
@SutuSebastian
Copy link
Collaborator

Fixed by #1498 in [email protected] release.

Please see Docs - Button - Button with label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants