Button in ButtonGroup ignores theme prop

[dhe128]

Steps to reproduce

<ButtonGroup theme={{position: {start: 'x'}}}>
  <Button />
</ButtonGroup>

Current behavior

First button in button group should have class="x"

Expected behavior

class="x" is missing

Context

Button component doesn't use props.theme of parent ButtonGroup.

flowbite-react/src/components/Button/Button.tsx

Line 118 in 4fd01e5

const { buttonGroup: groupTheme, button: buttonTheme } = getTheme();

[SutuSebastian]

Known issue, its because ButtonGroup uses React.cloneElement under the hood to inject some props, but does not apply top level theme override configuration.

Will be fixed in the next patch.

[WojciechCzechowski-SmartFrame]

Known issue, its because ButtonGroup uses React.cloneElement under the hood to inject some props, but does not apply top level theme override configuration.

Will be fixed in the next patch.

More than a year / couple of patches later and it's still not fixed... :|

[zoltanszogyenyi]

Hey @WojciechCzechowski-SmartFrame,

Flowbite React is primarily an open-source library, you're more than welcome to contribute to it.

We're really doing our absolute best to keep the library not only updated, but bring new features.

I hope that you can understand this context too.

If you're a pro version holder, we've been doing a lot of updates and releases lately and we keep doing so since 4 years of our launch.

We're doing a major upgrade with @SutuSebastian that will upgrade to Tailwind v4 and do major improvements to the way you can theme components, so probably that's why it has been postponed until now since it should be fixed in a much larger update that will cover everything more extensively.

Thanks,
Zoltan

[SutuSebastian]

Fixed by #1498 in [email protected] release.