Skip to content

Improve color system to update the primary color from one place (blue, cyan, etc) #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rootical opened this issue Jul 5, 2023 · 5 comments
Labels
discussion It is not a bug or an enhancement 🚀 enhancement New feature or request
Milestone

Comments

@rootical
Copy link

rootical commented Jul 5, 2023

Hi all, thanks for the great work.

Changing to tailwind merge and improving theming is nice! But why would you completely change the colors, especially when https://flowbite.com is all still blue not cyan?

Obviously, this will cause users to not update at all (I understand the lib is in active development). I am lazy to go now and retheme every checkbox or select through the whole project :) Is there any way blue styles are coming back?

@zoltanszogyenyi
Copy link
Member

zoltanszogyenyi commented Jul 5, 2023

Hey @rootical,

Thanks for the kind words!

It's based on our strategy to give Flowbite React a unique identity just the same way we did with:

However, together with @tulup-conner and @rluders we've already been discussing a way to very easily update the primary colors from your talwind.config.js file from cyan to blue or to red or any other HEX or RGBA color of your choosing - this will be properly be documented as well.

Hopefully that makes sense! We should make switching between colors a breeze so in a way updating it back to blue should happen seamlessly without having to dig into all the cyan color codes.

One suggestion from me personally would be to simply find and replace all -cyan- tags to -blue-.

Cheers,
Zoltan

@rootical
Copy link
Author

rootical commented Jul 5, 2023

when in Rome do as the Romans do... but it should have been a patch release, not a minor :) And doing such a significant change would be great to have documented config for getting back and not breaking the whole color scheme with the release, not after.
Looking forward to knowing how to quickly get back the color scheme, thank you!

@zoltanszogyenyi zoltanszogyenyi changed the title Why did you change colors? Improve color system to update the primary color from one place (blue, cyan, etc) Jul 10, 2023
@tulup-conner tulup-conner added the 🚀 enhancement New feature or request label Jul 12, 2023
@rgwebcode
Copy link

rgwebcode commented Jul 17, 2023

Yeah, this threw me off as well.
After updating the modules suddenly all my button colors changed, I mean wtf why? You shouldn't have changed that without providing an easy way to restore the previous default (which you now are still only discussing at it seems).

// Edit
By the way, replacing all occurrences of -cyan- with -blue- in the module files will break the cyan theme on some of these components as well, so if you don't want to break this functionality, you will have to change back the entries for any file that has a cyan: or cyanToBlue entry.

@rluders rluders added this to the 1.0.0 milestone Jul 25, 2023
@rluders
Copy link
Collaborator

rluders commented Jul 25, 2023

I think that we should have multiple themes included by "default" for the library.

  • Standard
  • React
  • Svelte
  • etc.

Opinions? Suggestions? How it can be done?

@rluders rluders added the discussion It is not a bug or an enhancement label Jul 25, 2023
@SutuSebastian
Copy link
Collaborator

Fixed by #1498 in [email protected] release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion It is not a bug or an enhancement 🚀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants