Skip to content

Make sure all composable components are wrapped with forwardRef #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
nigellima opened this issue Sep 5, 2023 · 2 comments
Closed
2 tasks done

Make sure all composable components are wrapped with forwardRef #945

nigellima opened this issue Sep 5, 2023 · 2 comments
Labels
help wanted Extra attention is needed 🚀 enhancement New feature or request

Comments

@nigellima
Copy link
Collaborator

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Summary

Composable components should be wrapped with forwardRef to allow users ref.

Context

Some components are not wrapped with forwardRef, which makes it impossible to pass a ref to them, like Table.Row. It would probably be beneficial to make an overall review and wrap all components that are exposed with a forwardRef
@rluders rluders added the 🚀 enhancement New feature or request label Sep 5, 2023
@rluders
Copy link
Collaborator

rluders commented Sep 23, 2023

This is VERY, VERY, VERY, VERY HIGHT PRIORITY! If someone could take it, I would be happy to pay you a beer once you visit the Czech Republic. 🤣

@rluders rluders added the help wanted Extra attention is needed label Sep 23, 2023
@SutuSebastian
Copy link
Collaborator

Fixed by #1498 in [email protected] release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed 🚀 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rluders @nigellima @SutuSebastian