nit pick to be more idiomatic

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

cmd/relayproxy/api/middleware/version.go

@@ -35,10 +35,3 @@ func VersionHeader(cfg VersionHeaderConfig) echo.MiddlewareFunc {
 func DefaultVersionHeaderSkipper(_ echo.Context) bool {
 	return false
 }
-
-// DDisableVersionHeaderSkipper returns a middleware.Skipper function that checks config.
-func DisableVersionHeaderSkipper(relayProxyConfig *config.Config) middleware.Skipper {
-	return func(_ echo.Context) bool {
-		return relayProxyConfig.DisableVersionHeader
-	}
-}

cmd/relayproxy/api/middleware/version_test.go

@@ -43,7 +43,9 @@ func TestNoVersion(t *testing.T) {
 		DisableVersionHeader: true,
 	}
 	middleware := middleware2.VersionHeader(middleware2.VersionHeaderConfig{
-		Skipper:          middleware2.DisableVersionHeaderSkipper(conf),
+		Skipper: func(c echo.Context) bool {
+			return conf.DisableVersionHeader
+		},
 		RelayProxyConfig: conf,
 	})
 	handler := middleware(func(c echo.Context) error {

cmd/relayproxy/api/server.go

@@ -73,7 +73,9 @@ func (s *Server) initRoutes() {
 	s.apiEcho.Use(middleware.CORSWithConfig(middleware.DefaultCORSConfig))
 
 	s.apiEcho.Use(custommiddleware.VersionHeader(custommiddleware.VersionHeaderConfig{
-		Skipper:          custommiddleware.DisableVersionHeaderSkipper(s.config),
+		Skipper: func(c echo.Context) bool {
+			return s.config.DisableVersionHeader
+		},
 		RelayProxyConfig: s.config,
 	}))
 

website/docs/relay-proxy/configure-relay-proxy.mdx

@@ -251,7 +251,7 @@ Enables Swagger for testing the APIs directly. If you are enabling Swagger you w
 - This field is used by Swagger to query the API at the right place.
 
 ### `disableVersionHeader`
-If `disableVersionHeader` is set to **`true`**, the relay proxy will not add the header `x-gofeatureflag-version` with the GOFF version in the HTTP response.
+If `disableVersionHeader` is set to **`true`**, the relay proxy will not add the header `x-gofeatureflag-version` with the GO Feature Flag version in the HTTP response.
 - option name: `disableVersionHeader`
 - type: **boolean**
 - default: **`false`**