fix: go-feature-flag provider add authentication header (open-feature#317)

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.spec.ts

@@ -133,14 +133,16 @@ describe('GoFeatureFlagProvider', () => {
           );
         });
     });
-    it('should throw an error if invalid api key is propvided', async () => {
+    it('should throw an error if invalid api key is provided', async () => {
       const flagName = 'unauthorized';
       const targetingKey = 'user-key';
       const dns = `${endpoint}v1/feature/${flagName}/eval`;
+      const apiKey = 'invalid-api-key';
 
       axiosMock.onPost(dns).reply(401, {} as GoFeatureFlagProxyResponse<string>);
 
-      await goff
+      const authenticatedGoff = new GoFeatureFlagProvider({ endpoint, apiKey });
+      await authenticatedGoff
         .resolveStringEvaluation(flagName, 'sdk-default', { targetingKey })
         .catch((err) => {
           expect(err).toBeInstanceOf(Unauthorized);
@@ -149,6 +151,33 @@ describe('GoFeatureFlagProvider', () => {
           );
         });
     });
+
+    it('should be valid with an API key provided', async () => {
+      const flagName = 'random-flag';
+      const targetingKey = 'user-key';
+      const dns = `${endpoint}v1/feature/${flagName}/eval`;
+      const apiKey = 'valid-api-key';
+
+      axiosMock.onPost(dns).reply(200, {
+        value: true,
+        variationType: 'trueVariation',
+        reason: StandardResolutionReasons.TARGETING_MATCH,
+        failed: false,
+        trackEvents: true,
+        version: '1.0.0',
+      } as GoFeatureFlagProxyResponse<boolean>);
+
+      const authenticatedGoff = new GoFeatureFlagProvider({ endpoint, apiKey });
+      await authenticatedGoff
+        .resolveBooleanEvaluation(flagName, false, { targetingKey })
+        .then((res) => {
+          expect(res).toEqual({
+            reason: StandardResolutionReasons.TARGETING_MATCH,
+            value: true,
+            variant: 'trueVariation',
+          } as ResolutionDetails<boolean>);
+        });
+    });
   });
 
   describe('resolveBooleanEvaluation', () => {

libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.ts

@@ -38,7 +38,11 @@ export class GoFeatureFlagProvider implements Provider {
   constructor(options: GoFeatureFlagProviderOptions) {
     this.timeout = options.timeout || 0; // default is 0 = no timeout
     this.endpoint = options.endpoint;
-    this.apiKey = options.apiKey;
+
+    // Add API key to the headers
+    if (options.apiKey) {
+      axios.defaults.headers.common['Authorization'] = `Bearer ${this.apiKey}`;
+    }
   }
 
   /**
@@ -170,19 +174,13 @@ export class GoFeatureFlagProvider implements Provider {
 
     let apiResponseData: GoFeatureFlagProxyResponse<T>;
     try {
-      const reqConfig: AxiosRequestConfig  = {
+      const response = await axios.post<GoFeatureFlagProxyResponse<T>>(endpointURL.toString(), request, {
         headers: {
           'Content-Type': 'application/json',
           Accept: 'application/json',
         },
         timeout: this.timeout,
-      };
-
-      if (this.apiKey) {
-        reqConfig.headers?.put('Authorization', `Bearer ${this.apiKey}`);
-      }
-
-      const response = await axios.post<GoFeatureFlagProxyResponse<T>>(endpointURL.toString(), request, reqConfig);
+      });
       apiResponseData = response.data;
     } catch (error) {
       if (axios.isAxiosError(error) && error.response?.status == 401) {