Skip to content

A new pull request #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
semjon00 opened this issue Apr 6, 2023 · 2 comments
Closed

A new pull request #159

semjon00 opened this issue Apr 6, 2023 · 2 comments

Comments

@semjon00
Copy link
Collaborator

semjon00 commented Apr 6, 2023 •
edited
Loading

Hello @thygate

A couple of days ago I created a pull request with some improvements. I guess no notification was sent to you about it. Could you please take a look?

#155

Thanks!
@thygate
Copy link
Owner

thygate commented Apr 7, 2023 •
edited
Loading

Hey sorry for the late reaction, there were some conflicts merging with my own code, and I've had my hands full between my professional and personal life.. I've decided to discard my commits and just merge your latest PR asap since it is a cleaner implementation.

@semjon00
Copy link
Collaborator Author

semjon00 commented Apr 7, 2023

Its ok. Thank you for your time! 🙂

@semjon00 semjon00 closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@semjon00 @thygate