🤖 Merge PR DefinitelyTyped#52168 [@types/passport-spotify] fix verifyFunction arguments order, expires_in is not optional by @teresaromero

Co-authored-by: Teresa <[email protected]>

Author: teresaromero

types/passport-spotify/index.d.ts

@@ -1,4 +1,4 @@
-// Type definitions for passport-spotify 1.1
+// Type definitions for passport-spotify 2.0
 // Project: https://github.com/jmperez/passport-spotify#readme
 // Definitions by: Rishi Kodali <https://github.com/rishikodali>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
@@ -46,18 +46,18 @@ export type VerifyCallback = (error?: Error | null, user?: object, info?: object
 export type VerifyFunction = (
     accessToken: string,
     refreshToken: string,
+    expires_in: number,
     profile: Profile,
-    done: VerifyCallback,
-    expires_in?: number,
+    done: VerifyCallback
 ) => void;
 
 export type VerifyFunctionWithRequest = (
     req: Request,
     accessToken: string,
     refreshToken: string,
+    expires_in: number,
     profile: Profile,
-    done: VerifyCallback,
-    expires_in?: number,
+    done: VerifyCallback
 ) => void;
 
 export class Strategy {

types/passport-spotify/passport-spotify-tests.ts

@@ -18,13 +18,15 @@ const strategyOptions: StrategyOptions = {
 const verifyFunction: VerifyFunction = (
     accessToken: string,
     refreshToken: string,
+    expires_in: number,
     profile: Profile,
     done: VerifyCallback,
 ) => {
     const user = {
         profile,
         accessToken,
         refreshToken,
+        expires_in
     };
 
     done(null, user);
@@ -43,13 +45,15 @@ const verifyFunctionWithRequest: VerifyFunctionWithRequest = (
     req: Request,
     accessToken: string,
     refreshToken: string,
+    expires_in: number,
     profile: Profile,
     done: VerifyCallback,
 ) => {
     const user = {
         profile,
         accessToken,
         refreshToken,
+        expires_in
     };
 
     done(null, user);