Skip to content

willDestroyElement not firing in {{each}} else #12716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amk221 opened this issue Dec 15, 2015 · 1 comment · May be fixed by tildeio/htmlbars#442
Closed

willDestroyElement not firing in {{each}} else #12716

amk221 opened this issue Dec 15, 2015 · 1 comment · May be fixed by tildeio/htmlbars#442
Labels
Bug Regression

Comments

@amk221
Copy link

amk221 commented Dec 15, 2015 

A.                            |     B.
{{#each items as |item|}}     |     {{#each items as |item|}}
  {{!...}}                    |        {{!...}}
{{else}}                      |     {{/each}}
  {{my-component}}            |     {{#unless items.length}}
{{/each}}                     |       {{my-component}}
                              |     {{/unless}}

In example A. the willDestroyElement hook is not firing for {{my-component}} when it is torn down.
It works for example B.
jsfiddle
Saranya-Raaj referenced this issue in Saranya-Raaj/htmlbars Jan 4, 2016
fixes [https://github.com/emberjs/ember.js/issues/12716](emberjs/embe…
deeb49b 
…r.js/#12716)
@Saranya-Raaj Saranya-Raaj mentioned this issue Jan 4, 2016
Open
@pgengler pgengler mentioned this issue Feb 4, 2016
Merged
Saranya-Raaj referenced this issue in Saranya-Raaj/htmlbars Feb 5, 2016
Revert "fixes [https://github.com/emberjs/ember.js/issues/12716](embe…
cc4e799 
…rjs/ember.js/#12716)"

This reverts commit deeb49b.
Saranya-Raaj pushed a commit to Saranya-Raaj/htmlbars that referenced this issue Feb 5, 2016
fixes emberjs/ember.js#12716
17893f1
Saranya-Raaj pushed a commit to Saranya-Raaj/htmlbars that referenced this issue Feb 5, 2016
fixes emberjs/ember.js#12716
3ea0c7d
@krisselden krisselden mentioned this issue Mar 19, 2016
Closed
45 tasks
@krisselden krisselden mentioned this issue Jun 30, 2016
Merged
7 tasks
@amk221
Copy link
Author

amk221 commented Jul 1, 2016

Thank you everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Cleanup morph of each else section Saranya-Raaj/htmlbars
4 participants
@stefanpenner @krisselden @amk221 @mmun