Use `packaging` package for backwards compatibility check #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

timvink opened this issue May 9, 2024 · 0 comments

Owner

timvink commented May 9, 2024 •

edited

Loading

We have this line:

mkdocs-git-revision-date-localized-plugin/mkdocs_git_revision_date_localized_plugin/plugin.py

Line 79 in b0ab74f

    
           theme_locale = custom_theme.locale if mkdocs_version >= "1.6.0" else custom_theme._vars.get("locale")

We should not compare strings directly, but compare the versions:

from packaging.version import Version

...
theme_locale = custom_theme.locale if mkdocs_version >= Version("1.6.0") else custom_theme._vars.get("locale")

timvink closed this as completed in

7ba52d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment