res.clearCookie now ignores maxAge. fixes expressjs#4851

Author: tjarbo

lib/response.js

@@ -805,6 +805,7 @@ res.get = function(field){
 
 res.clearCookie = function clearCookie(name, options) {
   var opts = merge({ expires: new Date(1), path: '/' }, options);
+  delete opts.maxAge;
 
   return this.cookie(name, '', opts);
 };

test/res.clearCookie.js

@@ -32,5 +32,18 @@ describe('res', function(){
       .expect('Set-Cookie', 'sid=; Path=/admin; Expires=Thu, 01 Jan 1970 00:00:00 GMT')
       .expect(200, done)
     })
+
+    it('should ignore maxAge', function(done){
+      var app = express();
+
+      app.use(function(req, res){
+        res.clearCookie('sid', { path: '/admin', maxAge: 900 }).end();
+      });
+
+      request(app)
+      .get('/')
+      .expect('Set-Cookie', 'sid=; Path=/admin; Expires=Thu, 01 Jan 1970 00:00:00 GMT')
+      .expect(200, done)
+    })
   })
 })