Implement the cloning steps for input elements

matthewp · domenic · commit 9ade70ef6444 · 2016-07-05T17:51:41.000-04:00
This implements the cloning steps for input elements by copying over the
value, checkedness, dirty value, and dirty checkedness properties to the
cloned input.
diff --git a/lib/jsdom/living/nodes/HTMLInputElement-impl.js b/lib/jsdom/living/nodes/HTMLInputElement-impl.js
@@ -7,7 +7,9 @@ const Event = require("../generated/Event");
 const mapper = require("../../utils").mapper;
 const createHTMLCollection = require("../../living/html-collection").create;
 const DOMException = require("../../web-idl/DOMException");
-const domSymbolTree = require("../helpers/internal-constants").domSymbolTree;
+const internalConstants = require("../helpers/internal-constants");
+const domSymbolTree = internalConstants.domSymbolTree;
+const cloningSteps = internalConstants.cloningSteps;
 const closest = require("../helpers/traversal").closest;
 const isDisabled = require("../helpers/form-controls").isDisabled;
 
@@ -380,6 +382,13 @@ class HTMLInputElementImpl extends HTMLElementImpl {
     }
     this.setAttribute("size", String(value));
   }
+
+  [cloningSteps](copy, node) {
+    copy._value = node._value;
+    copy._checkedness = node._checkedness;
+    copy._dirtyValue = node._dirtyValue;
+    copy._dirtyCheckedness = node._dirtyCheckedness;
+  }
 }
 
 module.exports = {
diff --git a/test/web-platform-tests/to-upstream.js b/test/web-platform-tests/to-upstream.js
@@ -17,6 +17,7 @@ describe("Local tests in Web Platform Test format (to-upstream)", () => {
     "dom/nodes/Element-tagName.html",
     "dom/nodes/attributes-namednodemap.html",
     "dom/nodes/getElementsByClassName-32.html",
+    "dom/nodes/Node-cloneNode-input.html",
     "dom/nodes/Node-isEqualNode.html",
     "dom/nodes/Node-mutation-adoptNode.html",
     "domparsing/DOMParser-dont-upstream.html",
diff --git a/test/web-platform-tests/to-upstream/dom/nodes/Node-cloneNode-input.html b/test/web-platform-tests/to-upstream/dom/nodes/Node-cloneNode-input.html
@@ -0,0 +1,52 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>Cloning of input elements</title>
+<link rel="help" href="https://dom.spec.whatwg.org/#dom-node-clonenode">
+<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone">
+<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone-ext">
+<link rel="help" href="https://html.spec.whatwg.org/multipage/forms.html#the-input-element:concept-node-clone-ext">
+
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+
+<script>
+"use strict";
+
+test(() => {
+  const input = document.createElement("input");
+  input.value = "foo bar";
+
+  const copy = input.cloneNode();
+  assert_equals(copy.value, "foo bar");
+}, "input element's value should be cloned");
+
+test(() => {
+  const input = document.createElement("input");
+  input.value = "foo bar";
+
+  const copy = input.cloneNode();
+  copy.setAttribute("value", "something else");
+
+  assert_equals(copy.value, "foo bar");
+}, "input element's dirty value flag should be cloned, so setAttribute doesn't affect the cloned input's value");
+
+test(() => {
+  const input = document.createElement("input");
+  input.setAttribute("type", "radio");
+  input.checked = true;
+
+  const copy = input.cloneNode();
+  assert_equals(copy.checked, true);
+}, "input element's checkedness should be cloned");
+
+test(() => {
+  const input = document.createElement("input");
+  input.setAttribute("type", "radio");
+  input.checked = false;
+
+  const copy = input.cloneNode();
+  copy.setAttribute("checked", "checked");
+
+  assert_equals(copy.checked, false);
+}, "input element's dirty checkedness should be cloned, so setAttribute doesn't affect the cloned input's checkedness");
+</script>
