Skip to content

Commit 727ab39

Browse files
zappolowskitony
authored andcommitted
fix(tests): explicitly state the shell to use
`tmux` uses the default login shell and thus tests might fail if this is not bash (or something compatible). Explicitly stating which shell to use circumvents issues arising from accidentally using another shell.
1 parent d63f9f5 commit 727ab39

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

Diff for: tests/workspace/test_builder.py

+26
Original file line numberDiff line numberDiff line change
@@ -880,6 +880,8 @@ def test_find_current_active_pane(server, monkeypatch):
880880
textwrap.dedent(
881881
"""
882882
session_name: Should not execute
883+
options:
884+
default-shell: /bin/bash
883885
windows:
884886
- panes:
885887
- shell_command: echo "___$((1 + 3))___"
@@ -893,6 +895,8 @@ def test_find_current_active_pane(server, monkeypatch):
893895
textwrap.dedent(
894896
"""
895897
session_name: Should not execute
898+
options:
899+
default-shell: /bin/bash
896900
windows:
897901
- panes:
898902
- shell_command:
@@ -907,6 +911,8 @@ def test_find_current_active_pane(server, monkeypatch):
907911
textwrap.dedent(
908912
"""
909913
session_name: Should execute
914+
options:
915+
default-shell: /bin/bash
910916
windows:
911917
- panes:
912918
- shell_command: echo "___$((1 + 3))___"
@@ -919,6 +925,8 @@ def test_find_current_active_pane(server, monkeypatch):
919925
textwrap.dedent(
920926
"""
921927
session_name: Should execute
928+
options:
929+
default-shell: /bin/bash
922930
windows:
923931
- panes:
924932
- shell_command:
@@ -932,6 +940,8 @@ def test_find_current_active_pane(server, monkeypatch):
932940
textwrap.dedent(
933941
"""
934942
session_name: Should not execute
943+
options:
944+
default-shell: /bin/bash
935945
windows:
936946
- panes:
937947
- shell_command:
@@ -946,6 +956,8 @@ def test_find_current_active_pane(server, monkeypatch):
946956
textwrap.dedent(
947957
"""
948958
session_name: Should not execute
959+
options:
960+
default-shell: /bin/bash
949961
windows:
950962
- panes:
951963
- shell_command:
@@ -960,6 +972,8 @@ def test_find_current_active_pane(server, monkeypatch):
960972
textwrap.dedent(
961973
"""
962974
session_name: Should execute
975+
options:
976+
default-shell: /bin/bash
963977
windows:
964978
- panes:
965979
- shell_command: echo "___$((1 + 3))___"
@@ -972,6 +986,8 @@ def test_find_current_active_pane(server, monkeypatch):
972986
textwrap.dedent(
973987
"""
974988
session_name: Should execute
989+
options:
990+
default-shell: /bin/bash
975991
windows:
976992
- panes:
977993
- shell_command:
@@ -1033,6 +1049,8 @@ def fn():
10331049
textwrap.dedent(
10341050
"""
10351051
session_name: Should not execute
1052+
options:
1053+
default-shell: /bin/bash
10361054
windows:
10371055
- panes:
10381056
- shell_command:
@@ -1049,6 +1067,8 @@ def fn():
10491067
textwrap.dedent(
10501068
"""
10511069
session_name: Should not execute
1070+
options:
1071+
default-shell: /bin/bash
10521072
windows:
10531073
- panes:
10541074
- shell_command:
@@ -1065,6 +1085,8 @@ def fn():
10651085
textwrap.dedent(
10661086
"""
10671087
session_name: Should not execute
1088+
options:
1089+
default-shell: /bin/bash
10681090
windows:
10691091
- panes:
10701092
- shell_command:
@@ -1079,6 +1101,8 @@ def fn():
10791101
textwrap.dedent(
10801102
"""
10811103
session_name: Should not execute
1104+
options:
1105+
default-shell: /bin/bash
10821106
windows:
10831107
- panes:
10841108
- shell_command:
@@ -1093,6 +1117,8 @@ def fn():
10931117
textwrap.dedent(
10941118
"""
10951119
session_name: Should not execute
1120+
options:
1121+
default-shell: /bin/bash
10961122
shell_command_before:
10971123
- cmd: echo "sleeping before"
10981124
sleep_before: .5

0 commit comments

Comments
 (0)