Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong query after sqlmesh format in Clickhouse dialect #4056

Closed
dnbnero opened this issue Mar 31, 2025 · 1 comment · Fixed by tobymao/sqlglot#4930
Closed

Wrong query after sqlmesh format in Clickhouse dialect #4056

dnbnero opened this issue Mar 31, 2025 · 1 comment · Fixed by tobymao/sqlglot#4930
Assignees
@VaggelisD
Labels
Bug Something isn't working

Comments

@dnbnero
Copy link

dnbnero commented Mar 31, 2025

After sqlmesh format clickhouse query is wrong if using values table function (https://clickhouse-docs.vercel.app/docs/sql-reference/table-functions/values)
Original query:

select
    type, id
from values(
    'id Int, type Int',
    (1, 1),
    (2, 1),
    (3, 1),
    (4, 1)
)

After format:

SELECT
  type,
  id
FROM (
  SELECT
    'id Int, type Int',
    (1, 1),
    (2, 1),
    (3, 1),
    (4, 1)
)

First query returining two columns and 4 rows, second query throws error
@georgesittas
Copy link
Contributor

georgesittas commented Mar 31, 2025 •
edited
Loading

@VaggelisD can you take a look please? It seems like VALUES(...) is now supported in ClickHouse so SQLGlot needs to take that into account. This isn't related to sqlmesh format, it's an AST generation issue.

@georgesittas georgesittas added the Bug Something isn't working label Mar 31, 2025
@VaggelisD VaggelisD mentioned this issue Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VaggelisD VaggelisD

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(clickhouse)!: Fix generation of exp.Values tobymao/sqlglot
3 participants
@VaggelisD @georgesittas @dnbnero